Giter Club home page Giter Club logo

Comments (3)

mrocklin avatar mrocklin commented on May 26, 2024

My guess is that query optimization will make more users happy than losing annotations will make users sad. Because of this, I'm in favor of merging in query optimization even if it disrupts annotations. I think that it's ok to make some existing users sad.

Of course I'd be happy to see a better solution here, but I wouldn't want this to slow things down much.

from dask.

hendrikmakait avatar hendrikmakait commented on May 26, 2024

I agree that query optimization will be of much bigger benefit than annotations for most users. However, I don't think breaking things silently will be a good UX for those users who are affected. To move forward quickly, I think that adding a warning to dask.annotate, which contains more information, might be a nice compromise. Similar to #10925, users should be able to silence this warning.

from dask.

mrocklin avatar mrocklin commented on May 26, 2024

Yup, I don't mind seeing improvements to annotations UX. However, I don't think that the release of query planning should be slowed down by this. I agree with scope, I wouldn't agree with a blocking change (not that you're proposing that) and I'm not sure how highly I would prioritize this (I don't see many users with annotations in dataframes). However, if you have different knowledge (for example if there has been evidence that people use annotations with dask.dataframe) then I could agree that it's worth prioritizing. If there has not been evidence that this is in use then I probably wouldn't bother (we have plenty of other high priority work to do) unless it's very easy.

from dask.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.