Giter Club home page Giter Club logo

Comments (3)

crusaderky avatar crusaderky commented on May 26, 2024

@fjetter offline you expressed concern for dask-expr optimization performance. I'm observing a 50~150ms slowdown for the full TPCH queries.
IMHO it's negligible.

runtime for graph definition + optimization.
Note that it incorporates fetching the metadata of the input dataframe from s3, which I suspect takes the lion share's of both the mean time and the variance (this is just an intuition; I didn't collect numerical evidence about it).
image

end-to-end runtime on the Coiled cluster:
image

The other TPCH queries show similar behaviour.

from dask.

crusaderky avatar crusaderky commented on May 26, 2024

All PRs are now only waiting for review

from dask.

crusaderky avatar crusaderky commented on May 26, 2024

Summary of changes

  • tokenize() is now deterministic, within the same interpreter, in most cases
  • in the rare edge cases where it is not, you can trust tokenize(..., ensure_determinstic=True) to raise robustly
  • there should be no expectation of determinism across interpreter restarts, hosts, OSs, or dependency versions

The issue of key collision on the scheduler (same key, but different run_spec and possibly different dependencies), which is chiefly caused by #9888, has been mitigated:

Legend

✔️ produces correct output
📛 cluster crashes or hangs on AssertionError
😕 task completes successfully, but output is wrong
⚠️ emits warning in the scheduler log

run_spec Task output Dependencies Old task status 2024.2.0 2024.2.1 Use case of #9888?
same same same * ✔️ ✔️ no
differs same same pending ✔️ ⚠️ ✔️ yes
differs same new task has fewer pending ✔️ ⚠️ ✔️ yes
differs same new task has more pending 📛 ⚠️ ✔️ yes
differs same same memory ✔️ ✔️ yes
differs same new task has fewer memory ✔️ ⚠️ ✔️ yes
differs same new task has more memory ✔️ ✔️ yes
differs same * released ✔️ ⚠️ ✔️ yes
differs differs same pending 😕 ⚠️ 😕 no
differs differs new task has fewer pending 😕 ⚠️ 😕 no
differs differs new task has more pending 📛 ⚠️ 😕 no
differs differs same memory 😕 😕[1] no
differs differs new task has fewer memory 😕 ⚠️ 😕 no
differs differs new task has more memory 😕 😕[1] no
differs differs * released 😕 ⚠️ 😕 no

[1] this is not great and could deserve a follow-up

from dask.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.