darylldoyle / gulp-email-creator Goto Github PK

View Code? Open in Web Editor NEW

167.0 167.0 19.0 36 KB

Gulp Email Creator

License: Apache License 2.0

JavaScript 50.01% CSS 22.43% HTML 27.56%

gulp-email-creator's People

Contributors

Stargazers

Watchers

Forkers

shrwnsan fnnzzz jmcneive reneruiz telekid matt-lavinia nallie captainhurst rapidwebltd winfredeu kcsk1nn3r renaco codingmaven bryant1410 abazhenov-4xxi pbermejo jozerozman chrismauck

gulp-email-creator's Issues

Windows 10 Error Installing

Hey, I've did a clean NPM/GULP install, but when i try to run "npm install" on project folder, i've got an error on node-sass.

C:\Users\danil\Desktop\project>gulp
C:\Users\danil\Desktop\project\node_modules\gulp-sass\node_modules\node-sass\lib\index.js:22
throw new Error('libsass bindings not found. Try reinstalling node-sass?');
^

Error: libsass bindings not found. Try reinstalling node-sass?
at getBinding (C:\Users\danil\Desktop\project\node_modules\gulp-sass\node_modules\node-sass\lib\index.js:22:11)
at Object. (C:\Users\danil\Desktop\project\node_modules\gulp-sass\node_modules\node-sass\lib\index.js:188:23)
at Module._compile (module.js:413:34)
at Object.Module._extensions..js (module.js:422:10)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)
at Module.require (module.js:367:17)
at require (internal/module.js:16:19)
at Object. (C:\Users\danil\Desktop\project\node_modules\gulp-sass\index.js:3:17)
at Module._compile (module.js:413:34)

Is it possible to make online testing features easy on/off?

If though I have downloaded everything I'm unable to use this tool offline

Getting this error

[22:23:59] Starting 'build'...

events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: Unable to connect to the MailChimp API endpoint.

CSS comments should not be stripped

MailChimp uses comments on the CSS to identify dynamic sections and such like so...

/*
    @tab Page
    @section background style
    @tip Set the background color and top border for your email. You may want to choose colors that match your company's branding.
    @theme page
    */
        body,#bodyTable{
            /*@editable*/background-color:#dee0e2;
        }
    /*
    @tab Page
    @section background style
    @tip Set the background color and top border for your email. You may want to choose colors that match your company's branding.
    @theme page
    */
        #bodyCell{
            /*@editable*/border-top:4px solid #BBBBBB;
        }
    /*
    @tab Page
    @section email border
    @tip Set the border for your email.
    */
        #templateContainer{
            /*@editable*/border:1px solid #BBBBBB;
        }
    /*
    @tab Page
    @section heading 1
    @tip Set the styling for all first-level headings in your emails. These should be the largest of your headings.
    @style heading 1
    */
        h1{
            /*@editable*/color:#202020 !important;
            display:block;
            /*@editable*/font-family:Helvetica;
            /*@editable*/font-size:26px;
            /*@editable*/font-style:normal;
            /*@editable*/font-weight:bold;
            /*@editable*/line-height:100%;
            /*@editable*/letter-spacing:normal;
            margin-top:0;
            margin-right:0;
            margin-bottom:10px;
            margin-left:0;
            /*@editable*/text-align:left;
        }

The current build process kills the comments. I'm uploading the compiled HTML to MailChimp.

I'll see if there's some flag that can be set to preserve the comments.

npm install fails with/without sudo

> [email protected] install /Users/rruiz/work/adp/growth-campaign/touch-2/email/gulp-workflow/node_modules/htmlstrip-native
> node-gyp rebuild

  CXX(target) Release/obj.target/htmlstrip/htmlstrip.o
../htmlstrip.cpp:195:31: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
Handle<Value> HtmlStrip(const Arguments& args) {
                              ^~~~~~~~~
                              v8::internal::Arguments
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
      ^
../htmlstrip.cpp:196:17: error: calling a protected constructor of class 'v8::HandleScope'
    HandleScope scope;
                ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:816:13: note: declared protected here
  V8_INLINE HandleScope() {}
            ^
../htmlstrip.cpp:200:13: error: member access into incomplete type 'const v8::internal::Arguments'
    if (args.Length() >= 2) {
            ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:127:7: note: forward declaration of 'v8::internal::Arguments'
class Arguments;
      ^
../htmlstrip.cpp:202:14: error: type 'const v8::internal::Arguments' does not provide a subscript operator
                args[0].As<Object>()->GetIndexedPropertiesExternalArrayData());
                ~~~~^~
../htmlstrip.cpp:202:21: error: 'Object' does not refer to a value
                args[0].As<Object>()->GetIndexedPropertiesExternalArrayData());
                           ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2110:17: note: declared here
class V8_EXPORT Object : public Value {
                ^
../htmlstrip.cpp:202:29: error: expected expression
                args[0].As<Object>()->GetIndexedPropertiesExternalArrayData());
                                   ^
../htmlstrip.cpp:203:20: error: type 'const v8::internal::Arguments' does not provide a subscript operator
                        inBufSize = args[1]->Uint32Value();
                                    ~~~~^~
../htmlstrip.cpp:209:16: error: no member named 'New' in 'v8::String'
                                                        String::New("HtmlStrip: Arguments must be a UTF-16 ...
                                                        ~~~~~~~~^
../htmlstrip.cpp:220:10: error: member access into incomplete type 'const v8::internal::Arguments'
                if(args.Length() >= 3){
                       ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:127:7: note: forward declaration of 'v8::internal::Arguments'
class Arguments;
      ^
../htmlstrip.cpp:221:32: error: type 'const v8::internal::Arguments' does not provide a subscript operator
      Local<Object> opts = args[2].As<Object>();
                           ~~~~^~
../htmlstrip.cpp:221:39: error: 'Object' does not refer to a value
      Local<Object> opts = args[2].As<Object>();
                                      ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2110:17: note: declared here
class V8_EXPORT Object : public Value {
                ^
../htmlstrip.cpp:221:47: error: expected expression
      Local<Object> opts = args[2].As<Object>();
                                              ^
../htmlstrip.cpp:223:13: error: no matching member function for call to 'Has'
                        if(opts->Has(include_script_sym)){
                           ~~~~~~^~~
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2144:8: note: candidate function not viable: no known conversion
      from 'Persistent<v8::String>' to 'Handle<v8::Value>' for 1st argument
  bool Has(Handle<Value> key);
       ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2152:8: note: candidate function not viable: no known conversion
      from 'Persistent<v8::String>' to 'uint32_t' (aka 'unsigned int') for 1st argument
  bool Has(uint32_t index);
       ^
../htmlstrip.cpp:224:28: error: no matching member function for call to 'Get'
                                include_script = opts->Get(include_script_sym)->ToBoolean()->Value();
                                                 ~~~~~~^~~
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2128:16: note: candidate function not viable: no known
      conversion from 'Persistent<v8::String>' to 'Handle<v8::Value>' for 1st argument
  Local<Value> Get(Handle<Value> key);
               ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2130:16: note: candidate function not viable: no known
      conversion from 'Persistent<v8::String>' to 'uint32_t' (aka 'unsigned int') for 1st argument
  Local<Value> Get(uint32_t index);
               ^
../htmlstrip.cpp:227:13: error: no matching member function for call to 'Has'
                        if(opts->Has(include_style_sym)){
                           ~~~~~~^~~
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2144:8: note: candidate function not viable: no known conversion
      from 'Persistent<v8::String>' to 'Handle<v8::Value>' for 1st argument
  bool Has(Handle<Value> key);
       ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2152:8: note: candidate function not viable: no known conversion
      from 'Persistent<v8::String>' to 'uint32_t' (aka 'unsigned int') for 1st argument
  bool Has(uint32_t index);
       ^
../htmlstrip.cpp:228:27: error: no matching member function for call to 'Get'
                                include_style = opts->Get(include_style_sym)->ToBoolean()->Value();
                                                ~~~~~~^~~
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2128:16: note: candidate function not viable: no known
      conversion from 'Persistent<v8::String>' to 'Handle<v8::Value>' for 1st argument
  Local<Value> Get(Handle<Value> key);
               ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2130:16: note: candidate function not viable: no known
      conversion from 'Persistent<v8::String>' to 'uint32_t' (aka 'unsigned int') for 1st argument
  Local<Value> Get(uint32_t index);
               ^
../htmlstrip.cpp:231:13: error: no matching member function for call to 'Has'
                        if(opts->Has(compact_whitespace_sym)){
                           ~~~~~~^~~
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2144:8: note: candidate function not viable: no known conversion
      from 'Persistent<v8::String>' to 'Handle<v8::Value>' for 1st argument
  bool Has(Handle<Value> key);
       ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2152:8: note: candidate function not viable: no known conversion
      from 'Persistent<v8::String>' to 'uint32_t' (aka 'unsigned int') for 1st argument
  bool Has(uint32_t index);
       ^
../htmlstrip.cpp:232:32: error: no matching member function for call to 'Get'
                                compact_whitespace = opts->Get(compact_whitespace_sym)->ToBoolean()->Value();
                                                     ~~~~~~^~~
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2128:16: note: candidate function not viable: no known
      conversion from 'Persistent<v8::String>' to 'Handle<v8::Value>' for 1st argument
  Local<Value> Get(Handle<Value> key);
               ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2130:16: note: candidate function not viable: no known
      conversion from 'Persistent<v8::String>' to 'uint32_t' (aka 'unsigned int') for 1st argument
  Local<Value> Get(uint32_t index);
               ^
../htmlstrip.cpp:235:13: error: no matching member function for call to 'Has'
                        if(opts->Has(include_attributes_sym)){
                           ~~~~~~^~~
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2144:8: note: candidate function not viable: no known conversion
      from 'Persistent<v8::String>' to 'Handle<v8::Value>' for 1st argument
  bool Has(Handle<Value> key);
       ^
/Users/rruiz/.node-gyp/0.12.2/deps/v8/include/v8.h:2152:8: note: candidate function not viable: no known conversion
      from 'Persistent<v8::String>' to 'uint32_t' (aka 'unsigned int') for 1st argument
  bool Has(uint32_t index);
       ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [Release/obj.target/htmlstrip/htmlstrip.o] Error 1

Unhandled 'error' event on $ gulp

node:6611) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
[23:21:21] Using gulpfile ~/dev/Gulp-Email-Creator/gulpfile.js
[23:21:21] Starting 'sass'...
[23:21:21] Starting 'browser-sync'...
[23:21:21] Finished 'browser-sync' after 65 ms
[23:21:21] Starting 'build'...
[23:21:21] Starting 'watch'...
[23:21:21] Finished 'watch' after 17 ms

events.js:160
throw er; // Unhandled 'error' event
^
Error: Unable to connect to the MailChimp API endpoint because getaddrinfo ENOTFOUND undefined.api.mailchimp.com undefined.api.mailchimp.com:443

Any idea?

MailChimp's CSS inliner is stripping my inpage styles which I want to have to responsive columns.

Update all dependencies

Half of all dependencies at the moment are out-of-date:
https://david-dm.org/darylldoyle/Gulp-Email-Creator#info=devDependencies&view=table

Let's set up a GreenKeeper, it will make the dependency updating easier.

Do i just need to add my mailgun account username and password in setting?

[question] devdeps

Hi Daryll,

Are these two dev dependencies in package.json redundant?

"through2": "^2.0.1",
"tiny-lr": "^0.2.1"

Can't seem to install on Win7 machine

I keep getting a node-gyp error. I googled it and found a hack that set the path to phython.exe in system variables.
It "installs" with npm install but when i run gulp i get an error:

Error: Cannot find module './build/Debug/htmlstrip.node'
at Function.Module._resolveFilename (module.js:470:15)
at Function.Module._load (module.js:418:25)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)

Didn't run into this with my pinguin machine!!

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.