Dart CLI commands hang on a slow/unstable internet connection due to analytics about sdk HOT 8 OPEN

I might check with the flutter CLI folks to see how they handle it.

from sdk.

Summary: Dart CLI commands, like dart run and dart test, hang when internet connectivity is slow or unstable due to analytics collection blocking the execution flow. This issue can be resolved by disabling analytics, but the process itself is also affected by the network latency.

from sdk.

In our previous implementation of analytics it was possible to get a future for the last item sent, wait on that for a brief time w/ a 100ms-200ms timeout, and exit the process if there was a delay in sending (to not hang the VM exit waiting for analytics). We've since re-written the analytics implementation; I'm not sure who's responsible for the integration into the dart cli, but @bkonyi would be the best person to start with.

from sdk.

In our previous implementation of analytics it was possible to get a future for the last item sent, wait on that for a brief time w/ a 100ms-200ms timeout, and exit the process if there was a delay in sending (to not hang the VM exit waiting for analytics). We've since re-written the analytics implementation; I'm not sure who's responsible for the integration into the dart cli, but @bkonyi would be the best person to start with.

Yeah, I'm responsible for the CLI. I thought Elias had done some work to account for this (I know the legacy analytics timeout behavior was brought up), but maybe this never ended up happening.

from sdk.

So this call: https://github.com/dart-lang/sdk/blob/main/pkg/dartdev/lib/dartdev.dart#L262

Should default to timing out after 250ms: https://github.com/dart-lang/tools/blob/main/pkgs/unified_analytics/lib/src/analytics.dart#L548

I wonder if there is some other code path by which we don't run this finally? Or some other async call to unified_analytics is hanging, before we get to the finally?

from sdk.

Hmm, when we timeout, we call _gaClient.close();, but I'm thinking maybe that doesn't cancel our pending requests?

https://github.com/dart-lang/tools/blob/main/pkgs/unified_analytics/lib/src/analytics.dart#L554

from sdk.

If I trace the code, it eventually gets to <IOClient>.close(), which does a .close(force: true), which should cancel pending requests.

from sdk.

If I trace the code, it eventually gets to <IOClient>.close(), which does a .close(force: true), which should cancel pending requests.

Ok, that makes sense. Also, assuming the flutter cli tool is not susceptible to this bug, then presumably Analytics.close() is closing these connections.

from sdk.