Giter Club home page Giter Club logo

Comments (1)

lrhn avatar lrhn commented on August 15, 2024

The example here is a little misleading. The join was written deliberately to not allocate a buffer if the iterable has only one element, so the extra lines at the beginning are there by choice.

Otherwise it would likely have been:

String join([String separator = ""]) {
  Iterator<E> iterator = this.iterator;
  if (!iterator.moveNext()) return "";
  if (separator.isNotEmpty) {
    while (true) {
      buffer.write(iterator.current);
      if (iterator.moveNext()) {
        buffer.write(separator);
      } else {
        break;
      }
    }
  } else {
    do {
      buffer.write(iterator.current);
    } while (iterator.moveNext());
  }
  return buffer.toString();
}

That has iterator.moveNext() at every point where a branch is needed, everywhere the two directions need to behave differently.

I have generally found that the moveNext() returning a bool and the current returning the value allows the branches to be put exactly where they are needed. It fits the algorithms I write.

Caching the last value of moveNext() is something you can always do (and possibly write wrapper class to help with), but most of the time it's not needed.
(It's likely true that every Iterator implementation has the necessary information to answer whether there is a current value, so it's also not impossible to add. It's just that it would be breaking for all existing implementations of Iterator, and I don't expect the benefit to be all that great.)

from sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.