Comments (1)
The example here is a little misleading. The join
was written deliberately to not allocate a buffer if the iterable has only one element, so the extra lines at the beginning are there by choice.
Otherwise it would likely have been:
String join([String separator = ""]) {
Iterator<E> iterator = this.iterator;
if (!iterator.moveNext()) return "";
if (separator.isNotEmpty) {
while (true) {
buffer.write(iterator.current);
if (iterator.moveNext()) {
buffer.write(separator);
} else {
break;
}
}
} else {
do {
buffer.write(iterator.current);
} while (iterator.moveNext());
}
return buffer.toString();
}
That has iterator.moveNext()
at every point where a branch is needed, everywhere the two directions need to behave differently.
I have generally found that the moveNext()
returning a bool
and the current
returning the value allows the branches to be put exactly where they are needed. It fits the algorithms I write.
Caching the last value of moveNext()
is something you can always do (and possibly write wrapper class to help with), but most of the time it's not needed.
(It's likely true that every Iterator
implementation has the necessary information to answer whether there is a current
value, so it's also not impossible to add. It's just that it would be breaking for all existing implementations of Iterator
, and I don't expect the benefit to be all that great.)
from sdk.
Related Issues (20)
- unintended_html_in_doc_comment triggers on some variants of allowed html tags in package:web HOT 1
- js_interop changes in 3.6 (master) to JSTypedArray subtypes break passing SharedArrayBuffer as the underlying buffer. HOT 3
- Dart analyzer fails to analyze condition in a list construction in enhanced enum constructor HOT 2
- [CP] Fix crashes due to unhandled StructuralParameterTypes in UP in the CFE HOT 1
- [dart2wasm][ffi] Error: Argument to 'Native.addressOf' must be annotated with @Native. HOT 3
- Macro with Map param doesn't work properly HOT 1
- [native assets] Add dynamic linking integration test for `dart` HOT 1
- Analyzer doesn't notice incorrect return type of generic method HOT 5
- [cfe/ffi] Cascading error on wrong types when using `.address` HOT 1
- Call dart function from a dynamic lib HOT 3
- [CP] Fix analysis_options.yaml "include:" for nested folders in workspace. HOT 1
- False positive in unintended_html_in_doc_comment lint HOT 2
- [breaking change] Compute closures of type schemas in the upper bound computations in the CFE as specified HOT 2
- Assists for adding and maybe removing digit separators from number literals
- [breaking change] Mark `IOOverrides` as `base` HOT 3
- A directory which is "excluded" via analysis options should not be searched for other analysis options. HOT 1
- Missing unnecessary `!` warning with nested extension types HOT 1
- Analysis Server Error HOT 1
- http library throws `HttpException: Connection closed before full header was received` without a stack trace HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk.