Giter Club home page Giter Club logo

Comments (5)

lrhn avatar lrhn commented on July 16, 2024

It caches the actual result, which is reasonable.
Only caching successful futures is more of a "retry" behavior than a cache.

Meaning that a cache which doesn't cache errors is a reasonable thing, but a different feature than this async cache.

We could have both, or the current cache could have a flag.

from async.

akmalviya03 avatar akmalviya03 commented on July 16, 2024

Creating a new class only for this functionality can be redundant, because AsyncCache and AsyncMemoizer are showing behaviour when error occurred. We can introduce a flag. What's your opinion on this?

from async.

lrhn avatar lrhn commented on July 16, 2024

A flag is probably the simplest approach.
Extra work which only happens if an error occurs should not be a problem.

Still means that the default will still be the current behavior.

from async.

akmalviya03 avatar akmalviya03 commented on July 16, 2024

Sure, adding a new flag with the name canRetry. Or should we name this flag something else?

from async.

akmalviya03 avatar akmalviya03 commented on July 16, 2024

Added new variable _canCacheException it's making more sense over canRetry

from async.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.