Giter Club home page Giter Club logo

Comments (1)

lrhn avatar lrhn commented on August 15, 2024

It's a tricky problem

I was about to suggest using a Finalizer or weak reference, but the disposer actually do need to retain a reference to the object, even if it's the last reference in the world, if the object still needs to be disposed.

The disposer's cancel operation does not need to retain the result, though. When the cancel becomes a no-op, it doesn't need to retain anything.

So the design here could work. I don't like safeCancel. I can't explain to people why not use safeCancel every time, so it should just be cancel and be the first cancel you find.
Then it will also be weird if it's not a method.

I can't find a good rewrite with those constraints, not with the current interface (same object provides both the operation and the cancel, so as long as the outer object is alive, someone might get the operation result, but the cancel keeps the outer object alive.
The solution here is to not keep the object alive through the tear-off, by not making it a tear-off.

Not sure I'm happy with any approach here. Might even be better to just do nothing, and recommend users keep the life-time of their disposer as limited as possible.

from async.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.