darksteel88 / leaguerankedscript Goto Github PK

The only two ways to get 404 are if the summoner ID is incorrect or the game doesn't exist for some reason. The former only occurs when there's a configuration error on the page. The latter has recently started occurring from Riot having problems with their advanced match history. That system and the matchlist endpoint for the API use the same foundation, so bugs in one appear in the other. With the bugs they had recently, some games straight up went missing, they didn't get tracked. As a result, the matchlist endpoint sometimes returns 404 on games even though the endpoint has been restored to working order.

The fix for this should be available soon, hopefully. It should be straight forward, we can check for 404 error and if it happens when we have more games to record, we skip it. If any games afterwards get populated, it means the game was missing.

Unfortunately, Riot's switch to Dynamic Queue broke this. For the moment being, there is nothing I can do and they cannot be processed. When Riot decides to address this issue, I will fix this as necessary.

We should add a method for tracking ranked teams and ranked 3s. It will likely be an additional option in the configuration page where you select the queue type.

For ranked teams, I don't think anything else will need to be done, since it's still the same game mode. We may want to decide whether we add a field for game mode, we may also just want to make users have a second spreadsheet all together for this information. I'm unsure which is best, because you could use the additional champion stats, but ranked doesn't translate entirely to solo queue, and you have to potentially add additional filters on other sheets that won't be fun to do.

For ranked 3s, we need to check how Riot determines roles in that game mode. I don't know if we get like top/bot/mid or top/bot/jungle or what, and we're probably not getting stuff like ADC/Support (though we certainly could). I may have to write a second spreadsheet with the appropriate headers and ask ranked 3 players to use that sheet.

We could always just skip ranked 3s since it's not very popular in comparison, and the people using this tend to be coming here after I've mentioned this in a summoner's rift ranked topic.

If you go to promo X a second time, it will automatically give you a free win. The script will see that you're 1-0 in promos and assume the current game was a promo game. This can be fixed by checking the LP amount the game before to see if it was 100, because we get to 100 LP one game before our promos. Of course, this will fail for users that don't update regularly but then it doesn't matter.

Apparently when you use the end point for summoner id, they strip whitespace from the username. Someone pointed out to me theirs was failing and thus is the result. need a fix for white space in that check.

I wanted to know because I followed the setup instructions, but I click run and it just says 'Finished Script' it adds my Summoner ID but nothing else populates.

Hi There,

i am getting the following error

TypeError: Cannot read property "teamid" from Undefined.

I am on the EUW Server so not sure if it is only a problem experienced on EUW

Great project btw

As per a request, some people want to track less data. I can modify the code to only populate data if the field exists. Some of them will still need to be tracked so I'll just always track those. I think in the function that checks for the header translation, we can insert a try/catch to catch the error when it's missing and send some clean message back to the user. It will also help in cases where it breaks, though I suspect that won't happen given my testing.

Need to add code to check Rift Heralds and then reverse populate it. It will be included for others going forward when they add the sheet column.

The sheet is supposed to get a list of all the games, figure out which one is the last one you've added, and then start from the next game forward. Sometimes, however, the filtering doesn't work, and it starts from the beginning. Need to take a look at why it happens. I can never reproduce it, it always works correctly the second time I run it, which is why it's so strange.

Hey awesome work, I'm just running into the same problem someone else ran into where the data won't load and I get an error of TypeError: Cannot read property "teamId" from undefined. Does this have to do with the api limitations on a non production key?

Again awesome work, I'm not a programmer so this stuff fascinates me lol.

Any help would be appreciated. Thanks.

All instances of comparing names should use lower case for comparisons otherwise it won't catch. Riot is inconsistent in where they use all lower or whatever you signed up with (capitals where you placed them).

So dynamic queue is totally going to mess up duo queue checking because you can solo queue with 5 players. As a result, we're just going to abandon the automatic check for duo queue and require users to track it manually. We'll have to update the spreadsheet with additional columns for all the duo queue members, or perhaps just keep it as one and make the user comma separate them or something. Either way, bottom line is the automatic check is being removed and it's going to be a manual feature.