darksinge / deep-cleaner Goto Github PK

Does this support typescript?

var obj = { 
  a: null, 
  b: {}, 
  c: [], 
  d: {
    e: 'value'
  }, 
  e: 'value' 
}

cleaner(obj, 'e');
console.log(obj);

I would expect :

{ 
  a: null, 
  b: {}, 
  c: [], 
  d: {}
}

but I get:

{ 
a: null, 
b: {}, 
d: {}
}

I will submit a fix and updated tests in a PR

Converting this module to use ES6 syntax to keep up to date with current trends and styles of JavaScript.

clean=require('deep-cleaner')
obj={a:{dirty:'toclean'}}
clean(obj,'dirty')

expected: obj={}
actual: obj= {a:{}}

maybe it's linked to another issue
clean=require('deep-cleaner')
obj2 = { a : { b : { c: {}} } }
clean(obj2,'dirty')

expected: obj2={}
actual: obj= {a:{b:{}}}

I noticed that version 2 was released as alpha-2 a year ago.

When cleaning an object, the passed in object should not be mutated.

const cleaner = require('deep-cleaner')
const obj = { dirty: 'value' }
const cleanObj = cleaner(obj, 'dirty')
assert.equal(obj.dirty, 'value')
assert.equal(cleanObj.dirty, undefined)

This new behavior will prevent side effects from occurring if the original object should not be modified.