darkerstar / geany-xml-encode Goto Github PK

Geany's new 1.26 API is being recommended for all future development. There is a transition path documented.

I would like to transition geany-xml-encode to the new API. In the short term, I might possibly support both the old API and the new API, but if there's ever a 1.0 release it will not support the old API.

Warning during compile:

xml-encode.c:166:14: warning: passing argument 1 of 'g_free' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]

When you highlight a selection then do "encode selection", the intention is that the selection after encoding is the same as the selection before encoding.

If #[ marks the start of the selection, and ]# marks the end, then when you encode the entities in:

lock, sto#[ck & bar]#rel

you should get:

lock, sto#[ck & bar]#rel

This works, but when you try to encode:

<a> #[<b/>]# </a>

you get:

<a> #[&lt;b/]#&gt; </a>

Note that the > is outside of the selection, while the > it was expanded from was inside.

The correct behaviour should be:

<a> #[&lt;b/&gt;]# </a>

Automake 1.12 introduced a new warning set -Wextra-portability. Unfortunately, these warnings got added to -Wall. Doubly unfortunately, one of the new warnings is triggered when AM_PROG_AR is not called before LT_INIT, which geany-xml-encode's configure.ac didn't do. And triply unfortunately, geany-xml-encode uses AM_INIT_AUTOMAKE([-Wall -Werror]), which now means that autoreconf (called via bootstrap) kills the build.