Giter Club home page Giter Club logo

Comments (3)

soroushzargar avatar soroushzargar commented on May 26, 2024

if (!PyArg_ParseTupleAndKeywords(args, keywds, "OO|ii", kwlist,

I remember you said we should make the input values obligatory in order to prevent issues made by default values. Shall I do it here and leave the default parameter assignment to the python wrapper?

Currently, I have done so but I ask just to get that if I was right doing that. If you say keep the defualts I will revert the change.

from lilcom.

soroushzargar avatar soroushzargar commented on May 26, 2024

inputArray = numpy.array([random.randrange(-(2**15), 2**15 - 1) for i in range (n_samples)]).astype(numpy.int16)

For testing, currently, I am creating an array using random-number generator. (I do acknowledge that it should be k-dimensional where k is not necessarily 1.) Is using random number generator enough for this step of test, or we should use a sample procedure to make it more real? I do realize that the next step of testing an audio file but my question here is restricted to very basic level of test.

from lilcom.

danpovey avatar danpovey commented on May 26, 2024

You can make them obligatory, sure.
Random number generator is good. We're just testing that it doesn't crash.
Make sure that you use a very wide range of scales; it's the denormal and nearly-infinite numbers that are likely to cause a crash, and those need to be tested.

from lilcom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.