Comments (13)
csukuangfj
commented on May 26, 2024
1
I just tried
pip install git+https://github.com/danpovey/lilcomand got the same error message as the one posted by @janvainer.
I think the problem is that pip install will try to run setup.py, but setup.py assumes that
numpy has already been installed.
from lilcom.
csukuangfj
commented on May 26, 2024
It is mentioned in setup.py:
Line 59 in 7feb4b2
It would be great if PyPI contains prebuilt wheel packages, so that pip install will install numpy automatically.
from lilcom.
danpovey
commented on May 26, 2024
OK.
…On Sat, Nov 21, 2020 at 8:40 PM Fangjun Kuang ***@***.***> wrote:
It is mentioned in setup.py:
https://github.com/danpovey/lilcom/blob/7feb4b22084b0952b5b889a348b650d2685ffb51/setup.py#L59
It would be great if PyPI contains prebuilt wheel packages, so that pip
install will install numpy automatically.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#24 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZFLO4HA67D64DXZB7IW4LSQ6YNFANCNFSM4T5YMMQA>
.
from lilcom.
danpovey
commented on May 26, 2024
Actually, can you LMK specifically what I have to do?
Previously I was doing:
python3 ./setup.py sdist; twine upload dist/*
For a binary distribution I think I'd need to compile it on a variety of
platforms (it contains C++ code).
…On Sat, Nov 21, 2020 at 10:14 PM Daniel Povey ***@***.***> wrote:
OK.
On Sat, Nov 21, 2020 at 8:40 PM Fangjun Kuang ***@***.***>
wrote:
> It is mentioned in setup.py:
>
>
> https://github.com/danpovey/lilcom/blob/7feb4b22084b0952b5b889a348b650d2685ffb51/setup.py#L59
>
> It would be great if PyPI contains prebuilt wheel packages, so that pip
> install will install numpy automatically.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#24 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAZFLO4HA67D64DXZB7IW4LSQ6YNFANCNFSM4T5YMMQA>
> .
>
from lilcom.
csukuangfj
commented on May 26, 2024
@danpovey
There is something called manylinux. See https://github.com/pypa/manylinux
In summary: a wheel compiled for manylinux can run not only on Ubuntu, Debian, but also on other
Linuxes, like CentOS, Redhat, etc. That is the meaning of many. This kind of wheel uses only
a limited set of C APIs that are supported by GLIBC on many Linux OSes.
from lilcom.
csukuangfj
commented on May 26, 2024
manylinux is not used for k2, since k2 depends on PyTorch, but PyTorch does not provide a wheel for manylinux after
version 1.5.0 or 1.3.0, I cannot remember the exact version.
from lilcom.
csukuangfj
commented on May 26, 2024
BTW: PyPI supports manylinux. So if you can build a manylinux wheel, it can be uploaded to PyPI so that
others can use pip install lilcom to install it instead of compiling lilcom from source.
from lilcom.
csukuangfj
commented on May 26, 2024
I would like to help if you do not have time.
from lilcom.
danpovey
commented on May 26, 2024
It would be great if you could help.
But I don't understand why pip can't know to install NumPy as a dependency
of lilcom if lilcom is to be built from source? I don't see what's so
difficult about that.
Building from source will tend to give more efficient code, which might be
a significant consideration.
…On Sat, Nov 21, 2020 at 10:31 PM Fangjun Kuang ***@***.***> wrote:
I would like to help if you do not have time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZFLO4SIZ6XBQ4WSUELQVTSQ7FMRANCNFSM4T5YMMQA>
.
from lilcom.
danpovey
commented on May 26, 2024
Maybe we need to create a requirements.txt?
…On Sat, Nov 21, 2020 at 11:16 PM Fangjun Kuang ***@***.***> wrote:
I just tried
pip install git+https://github.com/danpovey/lilcom
and got the same error message as the one posted by @janvainer
<https://github.com/janvainer>.
I think the problem is that pip install will try to run setup.py, but
setup.py assumes that
numpy has already been installed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZFLO5764VZB74DEDUAQQDSQ7KWNANCNFSM4T5YMMQA>
.
from lilcom.
csukuangfj
commented on May 26, 2024
Maybe we need to create a requirements.txt?
I tried it locally once again with a requirements.txt inside the project but it does not help. It has the same error.
from lilcom.
danpovey
commented on May 26, 2024
I think the problem may be that the setup.py calls numpy.get_include(), and
it imports numpy.
…On Sat, Nov 21, 2020 at 11:39 PM Fangjun Kuang ***@***.***> wrote:
Maybe we need to create a requirements.txt?
I tried it locally once again with a requirements.txt inside the project
but it does not help. It has the same error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZFLOZNZMEV72G5U3KFIG3SQ7NMJANCNFSM4T5YMMQA>
.
from lilcom.
danpovey
commented on May 26, 2024
See if you can find the answer from here
https://stackoverflow.com/questions/54117786/add-numpy-get-include-argument-to-setuptools-without-preinstalled-numpy
…On Sat, Nov 21, 2020 at 11:45 PM Daniel Povey ***@***.***> wrote:
I think the problem may be that the setup.py calls numpy.get_include(),
and it imports numpy.
On Sat, Nov 21, 2020 at 11:39 PM Fangjun Kuang ***@***.***>
wrote:
> Maybe we need to create a requirements.txt?
>
> I tried it locally once again with a requirements.txt inside the project
> but it does not help. It has the same error.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#24 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAZFLOZNZMEV72G5U3KFIG3SQ7NMJANCNFSM4T5YMMQA>
> .
>
from lilcom.
Related Issues (20)
- Make sure reconstruction test is runnable end to end HOT 8
- Release HOT 4
- Testing multi-platform reproducibility HOT 1
- Big-endian system test HOT 2
- liblto_plugin.so not found HOT 2
- In file included from lilcom/lilcom_extension.cc:15: In file included from lilcom/compression.h:6: lilcom/int_stream.h:7:10: fatal error: 'vector' file not found #include <vector> ^~~~~~~~ 1 error generated. error: command 'gcc' failed with exit status 1 HOT 15
- lilcom fails to compress Fortran contiguous arrays. HOT 1
- Speeding up lilcom decompression HOT 2
- Compression fails on non-contigous feats HOT 2
- Protocol "https" not supported or disabled in libcurl HOT 2
- Error when installing lhotse HOT 1
- Issue installing HOT 10
- can't be installed HOT 5
- Build lilcom failed. Please check the error message. -- solved! HOT 4
- ValueError: lilcom: Length of string was too short HOT 7
- Error when installing lhotse HOT 4
- Lilcom numpy version requirements. HOT 4
- Import issues after upgrading to version 1.6 HOT 5
- requirements, why? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lilcom.