Should probably be along the lines of:

victor to-svg RUBY_FILE [SVG_FILE] --watch

and to use the FileWatcher gem

There are multiple issues with the Ruby code generation:

1. It creates quoted numeric attributes:

setup width: "100", width: "100"
# instead of the expected
setup width: 100, width: 100

2. It does not convert attributes-with-hyphens to attributes_with_underscores

g "font-size": 30, "font-family": "arial", fill: "white" do
  # ...
end

To make victor-cli more useful, maybe we should consider these:

• Add victor init [RUBY_FILE] command, that will save a sample - this template should be special - without the svg.save and maybe without the initial Victor::SVG.new.
• Add victor to-svg RUBY_FILE [SVG_FILE] command that will run and save/generate the Ruby file.
• Rename the generate command to something like to-ruby to avoid the "what are we generating" confusion.
• Maybe add victor icodi STRING [SVG_FILE] that generates icodi icon?

@gingermusketeer thoughts?

Reproduction

Save this as dev/bug.svg:

<svg>
<style type="text/css">
<![CDATA[
  * { color: black }
]]>
</style>

<circle cx="58" cy="32" r="4" fill="black"/>
</svg>

Run this:

$ PRETTY_TRACE=full bundle exec victor to-ruby dev/bug.svg

Get this:

NoMethodError
undefined method `map' for "* { color: black }":String
Did you mean?  tap

Same problem occurs with text nodes:

<svg>
<text x="15" y="15" font-size="14" font-family="Verdana">
  You are
  <tspan fill="red" font-weight="bold">
  not
  </tspan>
  a banana
</text>
</svg>

Need to handle this Victor feature:

If the value of an attribute is a hash, it will be converted to a style-compatible string:

svg.rect x: 0, y: 0, width: 100, height: 100, style: { stroke: '#ccc', fill: 'red' }
# => <rect x=0 y=0 width=100 height=100 style="stroke:#ccc; fill:red"/>

That will just write a basic template ruby file to current directory.

The CodeGenerator class is the opposite of RubyCode. So perhaps they should be normalized to:

• Have similar interfaces
• Have similar names describing what they are, not what they do (RubySource, SVGSource ?)

Reproduction code

Use this sample.svg

<svg>
  <!-- this comment is converted to the word 'comment' -->
  <rect x="10" y="10" width="120" height="80"/>
</svg>

Run this:

$ victor to-ruby sample.svg

Get this output:

require "victor"

svg = Victor::SVG.new
svg.build do
  comment   # <-- this should not be here
  rect x: "10", y: "10", width: "120", height: "80"
end

svg.save "generated"

When running victor to-svg file.rb on a file with syntax errors, the output is less helpful than it can be:

$ victor to-svg dev/error.rb
NameError: undefined local variable or method `problem' for #<Victor::CLI::RubyCode:0x0000555e08a41aa8>

Running with DEBUG=1 is slightly better, since it shows backtrace, but this is not user friendly and the output is ugly:

$ DEBUG=1 victor to-svg dev/error.rb

This needs some attention.

Typing to-ruby and to-svg is no fun.

How about

• victor import - to import SVG and convert it to Victor Ruby
• victor render - to render Victor Ruby to SVG

@gingermusketeer thoughts?

CSS is currently not converted properly. This requires some thought as to whether the way Victor itself handles CSS is the best or not, and might require refactoring the Parser + SVGSource classes to work differently.

Also, we might require the aid of some lightweight CSS parser, like the css_parser gem.