Giter Club home page Giter Club logo

Comments (6)

danielr18 avatar danielr18 commented on June 21, 2024

Hello,

1 - Not sure if this is supported by Next.js Router, I think it's required to pass an URL, and if you are using an URL object, that would mean the pathname.

2 - I can't recreate this in the basic example, is it possible for you to create a minimal reproduction I can check?

from connected-next-router.

pavel06081991 avatar pavel06081991 commented on June 21, 2024

@danielr18 sorry now I've read more about next js router and how it works. The described issues are not issues. But I found another issue. When I use push method with shallow: true param like this:

    push({ pathname, query }, { pathname, query }, { shallow: true })

then url in browser is updated with new query params but in redux state related to router there are no changes.

Updated: Hmm and even without { shallow: true } param router redux state is not changed.

P.S in documentation it is written that now version 1 is available. But on npm the latest version is 0.0.7

from connected-next-router.

danielr18 avatar danielr18 commented on June 21, 2024

Can you create a minimal reproduction in codesandbox or a repository?

And yes, it's a mistake that 0.0.7 is marked as latest, it's because that's the last version that was published, v0 is for Redux v5 and v1 is for Redux v6 and v7.

from connected-next-router.

danielr18 avatar danielr18 commented on June 21, 2024

Closed due to inactivity

from connected-next-router.

Guneetgstar avatar Guneetgstar commented on June 21, 2024

Yes redux state doesn't change calling push action from the props

from connected-next-router.

Guneetgstar avatar Guneetgstar commented on June 21, 2024

But it didn't work in case of an error page only -_-

from connected-next-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.