Giter Club home page Giter Club logo

Comments (3)

DZakh avatar DZakh commented on June 26, 2024 1

Thanks for your honest answer. I'll remove the lib from my project and consider using the next/router instead. But before this, I'm gonna leave a few PRs with code that made the lib work for me to some point.

from connected-next-router.

danielr18 avatar danielr18 commented on June 26, 2024

Hi @DZakh, I agree with your concern, one of the purposes of the library is to have an easy drop-in replacement for connected-react-router when migrating a codebase to Next.js, but this is a problem I've encountered myself for example in getInitialProps where the route in the reducer is still the one you are currently in.

I don't think it would be right to set the location in routeChangeStart, imagine that you have a page that displays the current location, and you navigate to another page with a getInitialProps that takes 5 seconds to complete, the result I think we would see is the new location being displayed for those 5 seconds even when you haven't transitioned to the next page yet.

About why you should use the library, I have a similar conclusion to the one in react-redux-router README.

This library is not necessary for using Redux together with the Next Router. You can use the two together just fine without any additional libraries. It is useful if you care about recording, persisting, and replaying user actions, using time travel. If you don't care about these features, just can use Redux and Next Router directly.

I would like to make this library more useful, so I'm open to discuss ideas to solve this issue, including routeChangeStart

from connected-next-router.

danielr18 avatar danielr18 commented on June 26, 2024

@DZakh Thanks for bringing this up. This should be fixed in V4 with the changes in patchRouter. There's now a test case that ensures Next Router state and the router state in Redux are equal on page load / navigation.

store.dispatch(onLocationChanged(locationFromUrl(Router.asPath)))

from connected-next-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.