daniellarsennz / gameon Goto Github PK

TODO: Qualify "notified" - is this referring to email notifications? Could #68 be a duplicate?

• If no tournament start date is defined, default to today's date
• Don't allow tournaments to start/end in the past.

Discovered a bug in our build-and-deploy GitHub Actions and thought I'd escalate to our newly formed ops team to resolve, rather than doing it myself 🤣 @dylan-apera I'll let you think about what might be happening based on the two findings I am about to report. Test if you can resolve them without scrolling beyond this description. My only comment below documents the two changes we need to perform.

1. I was working on a feature branch and the Deploy Web App action was triggered with every push, this should not happen unless and until I push to main as it will break the production build.
2. After finishing development on the feature branch, I created a pull request and saw that it began firing again.. building and deploying the app as part of the automated 'CI checks' before I could merge the PR. This should also not happen until the PR is merged to main (see screenshot below).

@dylan-apera @DanielLarsenNZ Please take a look at the Deploy Web App action you put together on Monday, and ensure it only triggers a build and deploy once code has merged to main, not when commits are made to other branches, or PRs are created/updated. Beware that the same bug may exist in the .NET action too.

DevOps task to create actions to automatically deploy backend from main

• dapr upgrade --runtime-version 1.0.0 -k
• Install-Package Dapr.Client -Version 1.0.0
• Trigger a release;
• restart the pods / containers / services

The idea here is that rules show up on the tournament page's overview (below the description). Entering these by hand may get messy and doesn't scale, therefore:

@DanielLarsenNZ I recommend we allow the owner to enter a URL link to a website / YouTube video that contains the sport's ruleset... and simply store this as a String (nullable) for each tournament.

This is the frontend story for #4.

This is a filter on GET /tournaments which is covered in #70.

• We want to think about "ending" tournaments upon their completion (rather than deleting them).
• If however, the tournament was created in error, no games were played, no players have joined etc.. then we might want to allow the deletion of a tournament.
• If the owner ends a tournament, we must ensure that the endDate is updated to today's date.

If a tournament is closed or has reached maxPlayers, the join button is not shown and a Full Capacity badge appears beside the tournament name.

TODO: Restrict registration on the backend, ie. throw an error if one or more players can't be added to the tournament because it has reached capacity. Or, when adding multiple players to the tournament, throw an error if not all can be added due to the capacity restriction.

• Auto redirect -> HTTPS / HTTPS only

• User can add another GameOn User (that already exists in GameOn) to a Tournament that they are in
• Backend
• Frontend UI @olafwrieden

@sbkoppens suggested swipe your badge when you play to lookup your AD identity and attribute it to the match

Backend task to retrieve profile images from AAD Graph API.

• Retrieve photos for me: GET me/photos
• Retrieve photos for other GameOn users: GET users/{user_id}/photos

TODO

• Set Owner and Player1 on Tournament POST. See also #4

Additional Success Criteria

• Given a new tournament is being created, when the user fills out its details then they are presented with a text field to enter a tournament name, description, and reward.

• App Insights script for frontend
• App Insights SDK for services

Pagination using ?skip and ?limit parameters.

Logging this as a bug

MSAL.NetCore.4.24.0.0.MsalUiRequiredException:
ErrorCode: invalid_grant
Microsoft.Identity.Client.MsalUiRequiredException: AADSTS65001: The user or administrator has not consented 
to use the application with ID 'api://GameOn.Api' named 'GameOn.Users'. Send an interactive authorization 
request for this user and resource.

https://docs.microsoft.com/en-us/azure/app-service/scenario-secure-app-access-microsoft-graph-as-user?tabs=command-line

Backend

• When submitting a score, please check that today is greater than or equal to the start date defined for the tournament.

We want to display the following stats for each tournament:

• Total Players
• Total Games Played
• Total Games over the last 7 days
• Total Games over the last 30 days

TODO: Qualify what this means, we can already share a link to the tournament which is then accessible by anyone inside the same tenant.

If this refers to adding a user, then this is a duplicate of #47 and should be closed.

Considerations:

• How many days does a player have to respond to a challenge? Is this dynamic based on type of sport?
• We need to store the challenged player IDs based on the current user (in /me endpoint?)
• Is there a grace period before a player can be challenged again by the same person? How's this stored?
• Should the Tournament Owner be able to toggle whether players can challenge each other for this tournament (ie. canChallenge boolean on /tournaments/{id})?
• We should also store the start and end date of the n-day challenge so that we can remind the players.

Proposed:

[
  {
    playerId: String, // ID of challenged player
    startDate: Date, // Date when competition started
    endDate: Date, // Date when competition ended
    daysLeft: Integer, // computed
    daysTotal: Integer, // computed
  }
]

On the front-end a player should be able to challenge another player by selecting this option from a dropdown next to the opponent's name on the leaderboard. This option should not be visible for a previously challenged player during a grace period. Somehow the player should be visually reminded of their currently outstanding challenges.

@DanielLarsenNZ any feedback on the above?

Additional Success Criteria

• Given the player has finished a game or match, when they submit a new score then they shall be able to provide an optional comment (e.g. "Dan beat Gavin 2 games to 1").
• /tournaments/results publishes to results service ( @ncostar ) will be completed with #83
• UI hooked up ( @olafwrieden )

Document all routes and parameters. Maybe serve docs on api.gameon.nz root directory.

@DanielLarsenNZ - Just pulled my hair out as to why I was getting error 204 - No Content on GET /tournaments. Isn't a 200 response with an empty array more suited in this scenario?

Given no tournaments exist for the tenant, when GET /tournaments is called, then we should get a 200 - OK and empty array because we are not saying it is an error that no data exists, there is just nothing there (hence []).

Have pulled this out of #8

• User can add any AAD User from the Tenant to a Tournament they are in. If that User does not exist in GameOn, they are created and added to the Tournament.
• Users from other Tenants cannot be added.

Design an endpoint that accepts the new owner's ID and updates the tournament's owner attribute accordingly.

Only the current owner of the tournament should be able to transfer his/her ownership to another player.
The old owner should remain in players[]

Questions

• What happens to scores?
• How do we retain historical records of who played who?

Constraints

• A player should be able to remove themselves.
• An Owner cannot remove themselves (must transfer ownership as in #25 before they are downgraded to Player and can remove themselves.
• Cannot leave once the tournament has ended (for historical reasons - is this valid?)

Players should be able to view closed tournaments they previously played in, but not submit new scores (think: locked conversations in GitHub)