danieldkim / geomodel Goto Github PK

when using 'best_bbox_search_cells' with a bbox that crosses a major (resolution 1) fault line (such as cells '8' and '9', an error is thrown.

Not using Node, so I haven't run the file, but the example proximity_fetch call seems to have the arguments out of order.

Firstly, thanks for the port. It's exactly what I need.

The call stack for my use case is something like this:

best_bbox_search_cells
min_resolution remains as 0 (not sure if this is expected or not)
cur_ne and cur_sw are initially empty strings
interpolation_count is passed empty strings
compute_box is passed an empty string

In the Java version, computeBox() would return the following when passed an empty string:

BoundingBox bbox = new BoundingBox(90.0f, 180.0f, -90.0f, -180.0f);

But in your JS version, the following code returns null:

if (!cell_) {
return null;
}

That later results in the following error in interpolation_count:

caught TypeError: Cannot call method 'getNorth' of null

at this line:

var cell_lat_span = bbox_sw.getNorth() - bbox_sw.getSouth();

Haven't provided a patch since I'm not sure of the best fix.

Thanks,

Eliot.