danielaristidou / deck Goto Github PK

@DanielAristidou

I think that the current structure of piles and deck might have a slight conceptual flaw that is worth examining.

I think that the structures mean that there is a possibility of losing cards. There is no central structure that knows where all the cards are and would be able to account for every card if needed to. Also, given

self.cards = [FaceCard(face, suit) for suit in Suit for face in Face for n in range(packs_of_cards)]

In the deck, I think that cards ought to keep track of what pack they belong to (these can just be numerically assigned, or similar).

It ought to be possible to, for example

assert(Deck.hasAllCards())

I think this might be mitigated by the Game class? I think that the deck ought to be able to know what cards it ought to have, and know when they are all returned and probably the Game ought to be able to say specifically where a given card is?

Thoughts?