The p4harmonize's discuss from danbrakeley

p4harmonize's Issues

Odd quoting in output

It looks like all the double quotes in p4harmonize's output are escaped in the log output, which is a little confusing. For example:

2023.12.15-20:13:45   --> Exec: p4 -p ssl:perforce.example.com:1666 -u jorgen -c ec2_ondemand_engine_sync_harmonize -x \"/tmp/p4harmonize_delete_3938411009.txt\" delete -c 45400
2023.12.15-20:13:45   --> Exec: p4 -p ssl:perforce.example.com:1666 -u jorgen -c ec2_ondemand_engine_sync_harmonize add -c 45400 -t text -I -f \"/home/ubuntu/ws/org-harmonize/Engine/Source/ThirdParty/CEF3/Build/linux/Toolchain-clang.cmake\"
2023.12.15-20:13:45   --> //proj/engine/Engine/Source/ThirdParty/CEF3/Build/linux/Toolchain-clang.cmake#3 - opened for add
2023.12.15-20:13:45   --> Exec: p4 -p ssl:perforce.example.com:1666 -u jorgen -c ec2_ondemand_engine_sync_harmonize revert -a -c 45400 \"/home/ubuntu/ws/org-harmonize/...\"
2023.12.15-20:13:45 Success! All changes are waiting in CL #45400. Please review and submit when ready.
2023.12.15-20:13:45 Remember to delete workspace \"ec2_ondemand_engine_sync_harmonize\"
2023.12.15-20:13:45 and local folder \"/home/ubuntu/ws/org-harmonize\"

Both the arguments to p4 delete are escaped in the terminal and the workspace name & local folder in the final status message, along with other messages. I wouldn't expect backslashes here -- it makes it hard to copy-paste the output to e.g. run a command manually or copy the path name.

Recommend Projects