daipenger / sound-physics Goto Github PK

Server crashed and the crash report seems to be blaming SoundPhysics.
I'm just pre-emptively posting this i.e., I haven't tried troubleshooting/isolating the conflicting mod yet... probably foamfix (though the mod does work fine with this mod setup when sound physics is loaded client side only). Anyways, here's the crash report in the meantime... oh and thanks for forking and updating the mod! Loving it. https://gist.github.com/Endmateria/187bcc9092bdb80c9df87278efaa79c3#file-crash-2017-04-19_22-23-53-server-txt

Just wondering if this was ever going to come to 1.10. Thanks!

The FastMath utility often gives better performance than Java's standard Math class. These are the results of a benchmark on my PC of StrictMath, FastMath, and Math.

Name     StrictMath      FastMath          Math Runs=10000000 Java 1.8.0_131 (1.8.0_131-b11) Java HotSpot(TM) Client VM (25.131-b11)
abs        4    1.0     13 3.1702      4 1.0171
acos      58    1.0    145 2.5009     57 0.9924
asin      55    1.0    115 2.0705     55 0.9955
atan      84    1.0     68 0.8105     84 1.0007
atan2    101    1.0    108 1.0697    100 0.9917
cbrt     121    1.0     95 0.7920    119 0.9898
cos       95    1.0     53 0.5573     73 0.7737
cosh     113    1.0     48 0.4292    113 0.9971
exp       91    1.0     33 0.3717     76 0.8419
expm1    104    1.0     43 0.4113    103 0.9916
hypot    100    1.0    108 1.0786    100 0.9997
log       82    1.0     72 0.8818     38 0.4740
log10    112    1.0    143 1.2806     38 0.3448
log1p     92    1.0    144 1.5593     92 0.9971
pow      258    1.0    184 0.7138    105 0.4074
sin       95    1.0     54 0.5717     77 0.8137
sinh     132    1.0     49 0.3723    128 0.9688
sqrt      12    1.0     12 0.9929     12 0.9934
tan      131    1.0     78 0.5965    110 0.8391
tanh      79    1.0     34 0.4302     79 0.9995

The integer number is the number of nanoseconds per operation (smaller is better) and the float number is the percentage of the time of the StrictMath class (smaller is better, < 1 is faster than StrictMath). As you can see, the exp() function is 2.3x faster in the FastMath class than standard.

I would love to see this mod continually updated. A pull request should be soon.

Hay since you updated to 1.12.2 that I would like to ask you that if i can have this on my modpack and upload it to Curse. This Pack is called Real Life Modpack and is only able to get it on Twitch app.

I am going INSANE because animals sounds are WAY over amplified and the distance you hear them at is over amplified . You need to WAY soften the animal sounds over distances and make them quieter. This NEEDS to be FIXED.
It just sounds like there is 100 animals right at my ear every where i go.
DO NOT MAKE THIS CLOSED BECAUSE YOU DON'T THINK ITS AN ISSUE.

I think the problem with this mod is that it isn't widely available. Would it be possible to contact SonicEther to ask for permission to upload this to Curse?

While there's no block between a sound source and the player, the sound always play at max or near max volume, unless you are out of range.

Here's a vid showing the problem (had to boost the brightness)
https://youtu.be/iam9HALXD0A

Sorry, it's just been a bit since I've seen it updated

Thanks for putting this update out, but I noticed that a few sounds can be heard at far too high volumes from far to distant. The only sounds that I've seen this occur for are things like droppers, dispensers, doors, etc. Basically, sounds from redstone blocks can be heard from 10+ chunks away as if they were right next to the player.

Thats all, i need 1.14.4 because my texutres packs(for cinematics) dont realyl support 1.12

I am playing a modpack which has forge multipart. It allows placing, for instance, more than one torch per block (when you place more than one the block becomes a tile entity, if I'm not mistaken).

When I break that block, the whole sound system crashes and I have no sound at all during the rest of the game.

I'm not sure if it's this mod's fault or multipart's. Is there a relatively simple fix for this issue?

I isolated the issue to this exception:

Exception in thread "Thread-13" [00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: java.lang.NullPointerException
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at codechicken.multipart.TMultiPart.collisionRayTrace(TMultiPart.scala:116)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at codechicken.multipart.TileMultipart$$anonfun$rayTraceAll$2.apply(TileMultipart.scala:351)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at codechicken.multipart.TileMultipart$$anonfun$rayTraceAll$2.apply(TileMultipart.scala:350)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at scala.collection.TraversableViewLike$Filtered$$anonfun$foreach$4.apply(TraversableViewLike.scala:197)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at scala.collection.Iterator$class.foreach(Iterator.scala:743)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at scala.collection.AbstractIterator.foreach(Iterator.scala:1174)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at scala.collection.IterableViewLike$Transformed$class.foreach(IterableViewLike.scala:44)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at scala.collection.SeqViewLike$AbstractTransformed.foreach(SeqViewLike.scala:37)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at scala.collection.TraversableViewLike$Filtered$class.foreach(TraversableViewLike.scala:196)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at scala.collection.SeqViewLike$$anon$5.foreach(SeqViewLike.scala:188)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at codechicken.multipart.TileMultipart.rayTraceAll(TileMultipart.scala:350)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at codechicken.multipart.TileMultipart.collisionRayTrace(TileMultipart.scala:343)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at codechicken.multipart.BlockMultipart.collisionRayTrace(BlockMultipart.scala:110)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at codechicken.multipart.BlockMultipart.func_180636_a(BlockMultipart.scala:66)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at net.minecraft.block.state.BlockStateContainer$StateImplementation.func_185910_a(BlockStateContainer.java:461)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at net.minecraft.world.World.func_147447_a(World.java:1087)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at net.minecraft.world.World.func_72901_a(World.java:930)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at com.sonicether.soundphysics.SoundPhysics.evaluateEnvironment(SoundPhysics.java:387)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at com.sonicether.soundphysics.SoundPhysics.onPlaySound(SoundPhysics.java:182)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at paulscode.sound.libraries.SourceLWJGLOpenAL.play(SourceLWJGLOpenAL.java:671)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at paulscode.sound.Library.play(Library.java:706)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at paulscode.sound.Library.play(Library.java:675)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at paulscode.sound.SoundSystem.CommandPlay(SoundSystem.java:2076)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at paulscode.sound.SoundSystem.CommandQueue(SoundSystem.java:2599)
[00:35:26] [Thread-13/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:-1]: 	at paulscode.sound.CommandThread.run(CommandThread.java:121)

MC version 1.11.2 Forge 12.20.1.2388
First off thank you so much for working on the mod. secondly found out it crashes when sounds from the Animania mod plays. Not sure if this is known or not. I can attach a crash report if you like here is the little exerpt that leads me to believe it is with animania.

net.minecraft.server.MinecraftServer Server thread error Encountered an unexpected exception
net.minecraft.util.ReportedException: Ticking entity
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:726)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:624)
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:240)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
at com.sonicether.soundphysics.SoundPhysics.calculateEntitySoundOffset(SoundPhysics.java:183)
at net.minecraft.entity.Entity.func_184185_a(Entity.java:1066)
at com.animania.common.entities.amphibians.EntityAmphibian.func_70637_d(EntityAmphibian.java:120)
at com.animania.common.entities.amphibians.EntityAmphibian.startJumping(EntityAmphibian.java:124)
at com.animania.common.entities.amphibians.EntityAmphibian.func_70619_bc(EntityAmphibian.java:153)
at net.minecraft.entity.EntityLiving.func_70626_be(EntityLiving.java:901)
at net.minecraft.entity.EntityLivingBase.func_70636_d(EntityLivingBase.java:2258)
at net.minecraft.entity.EntityLiving.func_70636_d(EntityLiving.java:680)
at net.minecraft.entity.EntityAgeable.func_70636_d(EntityAgeable.java:171)
at net.minecraft.entity.passive.EntityAnimal.func_70636_d(SourceFile:39)
at com.animania.common.entities.amphibians.EntityAmphibian.func_70636_d(EntityAmphibian.java:207)
at net.minecraft.entity.EntityLivingBase.func_70071_h_(EntityLivingBase.java:2088)
at net.minecraft.entity.EntityLiving.func_70071_h_(EntityLiving.java:384)
at net.minecraft.world.World.func_72866_a(World.java:1965)
at net.minecraft.world.WorldServer.func_72866_a(WorldServer.java:840)
at net.minecraft.world.World.func_72870_g(World.java:1934)
at net.minecraft.world.World.func_72939_s(World.java:1748)
at net.minecraft.world.WorldServer.func_72939_s(WorldServer.java:621)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:720)
... 4 more

Any way to have note blocks "ignore" intervening blocks, the same way the jukeboxes are currently implemented?

Also, thank you for picking up this project. Sound has too long been the underdog to graphics in the gaming world.

Sounds in the Nether can be very difficult to hear.
Considering that sound absorption is lower the drier air is (and the fact, that sounds get absorbed too strongly in the nether), different settings for each dimension or even better biome could easily solve that problem.

When using this mod sometimes the game lags to 0fps for about a minute.

It seems like this project hasn't been touched in a while, but would it be possible to update this mod to 1.12.2, the latest version as of writing? It shouldn't be too different from 1.12.1

Hi. How can I contact you? I usually use the curseforge and im lost here. I cant find anything here. Can you help me? Thank you for your attention.

Typically, Gradle projects include the entire gradle/ directory to ensure repeatable builds. The wrapper is designed to be included in your VCS and is very lightweight.
This can be fixed by removing the gradle entry from the .gitignore file and adding and commiting the newly recognized files.

Hi!

I was toying around with the idea of implementing speed of sound to this mod, but alas my Minecraft modding skills and lack of free time just make it impossible for me to implement it.
I was wondering if you would be interested in implementing it?

P.S. Huge thanks for you up-keeping this mod up to date! 👍

Can i get other link for resourcepack?

When we were using it, we could hear simply jetpacks 2 sounds even when we were far away from each other. Had to disable the sounds in the config.

Dynamic Surrounding , Footsteps are muted or volume not passed on to Pauls code

I think it might be a good idea to consider supporting a vast majority of versions including 1.7.10 and perhaps have them on separate branches?

version of minecraft forge, 1.12.2 14.23.5.2847

version of mod, 1.0.4-1.12.1-rolloff

also using dynamic surroundings.

issue, footsteps on snow, grass, and possibly other surfaces sound way too muffled.

please help?

class name changes from 1.12 to 1.12.1

Compiling with JDK Java compiler API.
C:\Users\ASUS\Dev\Sound-Physics\build\sources\main\java\com\sonicether\soundphysics\SPGuiFactory.java:37: error: cannot find symbol
public RuntimeOptionGuiHandler getHandlerFor(RuntimeOptionCategoryElement element) {
^
symbol: class RuntimeOptionGuiHandler
location: class SPGuiFactory
1 error
:compileJava FAILED
:compileJava (Thread[Daemon worker,5,main]) completed. Took 0.692 secs.

FAILURE: Build failed with an exception.

I assume it's reasonable to think that competent mod developers should be able to compile this code. So I think we should perhaps remove them?

#11

Some sounds are barely hearable, and some are very loud. Footsteps are always playing in player position, even when its a mob. Is there a way to fix it?