dabomstew / pokecrystal-speedchoice Goto Github PK

Just add it as another choice under EXP with normal and BW

With Easy Clair option off (Vanilla Clair), talking to her again after beating her (but before completing the Dragon's Den shrine), she gives her TM.

The problem appears to arise from the the .FightDone and .AlreadyGotBadge labels of BlackthornGymClairScript in BlackthornGym1F.asm.

Assuming you've beaten her but haven't done the den:
Talking to her, it checks EVENT_BEAT_CLAIR (true) which jumps to .FightDone
Next it checks EVENT_GOT_TM24_DRAGONBREATH (false) which jumps to .AlreadyGotBadge
It checks EVENT_GOT_TM24_DRAGONBREATH again, which if true would skip over the .GiveTM label, however since it is false, if flows into the .GiveTM label where she gives the TM

I think adding checks in the .FightDone label to check for EASY_CLAIR_BADGE and also possibly adding an event for passing the Dragon Shrine test would be needed to fix it.

I will try to fix it in a fork, test it out, and put in a pull request.

See title. Code indicates that the "got item" sound should play when receiving a flag (e.g. pokegear from its vanilla location), but no sound is played. This bug has unfortunate interactions with instant text, since it makes it extremely easy for a player to miss seeing that they received a flag.

show DVs on done screen and/or enable a means to see DVs on status screen after seeing done screen

Vanilla - duh
Gen6/7 - exp share gets its gen6/7 effect (becomes key item) and all participants get 100% regardless
Gen8 - same as above except no item required, always happens. Exp share becomes completely useless

Off/on, on should act as if you killed it and apply all splitting etc appropriately

I've opened an issue in main repo of the project, but was not updated in a bunch of years so I don't expect any kind of answer from xCrystal: xCrystal/crystal-randofuser#6

I think compatibility between both projects will be an amazing idea and can open the possibility to start races with Randofuser. The new mechanic of Crystal Randofuser it's pretty solid, so much fun like full randomized runs of Gen 1 & 2. But for now it's so much time wasted skipping text or dealing with Rocket faction, which took me x2, almost x3, the time to complete it compared to a regular randomized + speedchoice one. This obviously kills the replay value of Randofuser.

Anyways, thank you so much for your work. I'm a veteran player of randomized runs and started combining it with Speedchoice since the beginning of the previous year and now there is no turning back. Now i'm carrying a modded GBC with a Ez Flash Jr. when i'm travelling, working abroad or in need to wait for something. This format helped a looooot staying at home due to Covid too, so have my eternal gratitude.

Grettings from Spain!

With Bike Music turned off, if you save and reload while on the bike, when you load back in, the bike music is playing. It's a minor thing that may not be worth fixing, but is it technically a bug.

Like red speedchoice. Obviously must be an option and off by default in the presets for now. Consider adding it to the presets in future releases if people like it.

The instructions in INSTALL.md appear to be out of date. In particular, they seem to rely on an old version of rgbds. Following the instructions and pulling the git branches listed there, I got the following error while running make in pokecrystal/:

pokecrystal$ make

rgbasm -o rgbdscheck.o rgbdscheck.asm
ERROR: rgbdscheck.asm(14):
    pokecrystal requires rgbds v0.6.0 or newer.
make: *** [Makefile:124: rgbdscheck.o] Error 1

However, it seems to work fine if you pull the current version of rgbds:

$ git clone --depth=1 https://github.com/rednex/rgbds

I then ran make -C against that directory, added it to the path manually, and both it and pokecrystal built fine on Ubuntu 21.04.1 LTS.

I'm not sure if this will work for everyone, though, and don't want to put in a PR without being able to check this myself.

With the Vanilla Clair, Instant Text, and Hold to Mash options turned on, Clair's text when she gives you the badge goes so fast, it is difficult to see what badge she actually gave you. Obviously this only applies to randomizers where the badges are randomized.

Is it possible to put an item's location on a board?
Example: "StormBadge is in Rainbow Wing Gift" or "Rainbow Wing Gift have an important item"
the map would also help: "StormBadge is in TinTower1F" or "TinTower1F have a...
(I would like to implement this to decrease seed time in randomizer)

Make it always generate after 1 cycle. Might also consider removing incest check since you can't breed two of the same manipped mon anyway so it serves no purpose other than randomly screwing people over.

Cygwin on Windows 10
rgbds v0.6.1

$ make

warning: gfx/pics.asm(1) -> constants.asm(53) -> constants/speedchoice_constants.asm(68): [-Wobsolete]
    `popalloptions: MACRO` is deprecated; use `MACRO popalloptions`
error: gfx/pics.asm(376):
    Section 'Pics 12' grew too big (max size = 0x4000 bytes, reached 0x4001).
error: gfx/pics.asm(583):
    Section 'Pics 16' grew too big (max size = 0x4000 bytes, reached 0x4001).
error: gfx/pics.asm(648):
    Section 'Pics 17' grew too big (max size = 0x4000 bytes, reached 0x400F).
error: Assembly aborted (3 errors)!
make: *** [Makefile:88: gfx/pics.o] Error 1

full make output is attached as make.log

Permaoption. Self explanatory.

Just make them always hatch in 1 cycle
Could also be added to the rando as a whole but that will take way more research

Copy red-speedchoice's approach and interface to view them. Hopefully SRAM space isn't an issue.

"It’s 251 settings + normal rockets + good early wilds + easy tin tower off" - snowbear

Like red speedchoice. Hide move selection menu, always choose metronome for both sides, and don't deduct any PP.

With the nickname prompt option turned off (so it should not ask for nicknames), you still get the prompt when hatching eggs.

"Also. Is it possible to add the sweet scent tm to the goldenrod tm mart after you grab it similar to rock smash and headbutt? It would be useful in a few niche cases potentially. The only problem is that bingo stuff might be disrupted by it." - snowbear

Maybe make it a separate option if it's going to be a big deal

"And then is it possible to have a turn off bike music setting in the options menu with the borders? I know some people wanted that as well lol" - snowbear