d8-contrib-modules / ga_login Goto Github PK

I have installed tfa and ga_login. I am able to get Drupal to render a QR code for authenticator. When I try to scan it with the authenticator app on my iPhone I get the following error:

"Invalid barcode"
"The barcode opaith://hotp/SITE-NAME-username?secret=SOMEHASH&counter=-1 is not a valid token barcode."

For debugging here are my current settings:

Removed the dependency on TFA from the composer.json file as it was conflicting with the tests.
When we move the module to d.o we need to add that dependency back.

• Allow the user to change the name prefix ( If you scan the QRCode in authenticator app the name which shows there is a combination of name prefix and your username )
• Allow the user to set the secret. The secret is what we use to encrypt the seed and is not configurable at this point. This needs more research as we have to shift the whole encryption part to Encrypt module.
• Show which otp method is enabled. The overview page only shows TFA enabled but not which validation TOTP or HOTP. Again fairly easy.
• Delete data when setup is cancelled. The HOTP counter is saved in the database and is not deleted when the setup is cancelled. This is fairly easy.

As a developer I would like the config screen here admin/config/people/tfa to do a better job explaining the difference between HOTP(one time code) vs TOTP(time based codes). I had to do a LOT of searching to understand what they were before I realized that the default most people want is TOTP

D8 is moving towards replacing drush make with composer. To support a composer based workflow this module should have a composer.json.

Given that this is an alpha the module is probably not going to be registered on packagist or drupal's packagist. In the interim Module should ship with instructions on how to add the module to a composer.json.