Comments (4)
MikeMcC399
commented on July 16, 2024
I am looking for guidance / confirmation regarding the suggestions I made for resolution before I submit a corresponding PR, especially for the strategy regarding the use of () => and function().
-
Current example tests in this repo use only the "fat arrow" / lambda construct
() =>. -
Cypress documentation uses both
() =>andfunction(). -
Mocha discourages passing it arrow functions as arguments.
from cypress-example-kitchensink.
MikeMcC399
commented on July 16, 2024
- I have submitted PR #633 to demonstrate a possible solution. I will leave it in draft status pending feedback about the solution strategy.
from cypress-example-kitchensink.
mjhenkes
commented on July 16, 2024
@MikeMcC399, your recommendations look good to me.
from cypress-example-kitchensink.
MikeMcC399
commented on July 16, 2024
-
Thank you for your valued feedback!
-
I have now set PR #633 ready for review. Perhaps you or one of your colleagues could pick up the PR now?
from cypress-example-kitchensink.
Related Issues (20)
- Node.js 12 deprecation warning in semantic-pull-request HOT 9
- Azure pipeline fails for PRs in fork HOT 4
- Sync of GitLab mirror copy HOT 4
- Test Issue HOT 2
- Azure DevOps CI stopped on April 3, 2023 HOT 3
- Parallel workflow fails HOT 2
- Several advanced examples fail cypress/unsafe-to-chain-command lint rule HOT 11
- Azure Pipelines example uses non-recommended code HOT 2
- GitHub Topics update HOT 4
- Outdated Heroku CI example HOT 4
- package.json `engines` lists Node.js 14 in end-of-life status HOT 5
- Installation deprecations caused by netlify-plugin-cypress HOT 2
- CircleCI checksum failure installing GoogleChrome in Windows with Chocolatey HOT 3
- CircleCI runs Windows tests under unsupported Node.js 14 - renovate fails HOT 5
- CircleCI wrong Node.js used for `linux-build` (v16.16.0) and `mac-build` (v18.16.0) HOT 1
- element selector: ":last" vs ":last-child" HOT 4
- IDE Shows false errors regards codebase under Ventura MacOS HOT 3
- Missing API commands HOT 3
- CircleCI fails to install the ChromeDriver HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cypress-example-kitchensink.