Several advanced examples fail cypress/unsafe-to-chain-command lint rule about cypress-example-kitchensink HOT 11 CLOSED

Hi @MikeMcC399 👋, thanks for logging this issue. I took a cursory look at the reported errors and the rule appears to be correct so we should do #2 and update the examples.

from cypress-example-kitchensink.

Hi @mschile

Thank you very much for qualifying this issue!

I can't provide a solution for this issue, so I would be happy for the core team to make the changes in the examples.

from cypress-example-kitchensink.

@jennifer-shehane

@MikeMcC399 I'd be fine with an update to the example recipes to reflect our new conventions. We just never revisited this.

This issue is still open because as I said previously I don't have the skills for this and nobody else has picked it up.

from cypress-example-kitchensink.

• I have proposed a fix for a related issue in #662. For the waiting issue I propose to ignore the rule.

from cypress-example-kitchensink.

@mschile

unsafe-to-chain is currently disabled in this repo pending update of the examples to conform to linting rules.

The latest new release from Aug 8, 2023 [email protected] causes additional 8 problems to be flagged if the rule is enabled:

✖ 59 problems (59 errors, 0 warnings)

instead of the previous

✖ 51 problems (51 errors, 0 warnings)

It would be good for the examples to be updated so that they can be used as a reference for what is correct. Perhaps this fix could be scheduled some time soon?

• See also cypress-io/eslint-plugin-cypress#140

from cypress-example-kitchensink.

Updating to [email protected] (current latest) causes now 59 "unsafe to chain" errors when checking with

  "rules": {
    "cypress/unsafe-to-chain-command": "error"
  }

The rule is currently disabled and waiting for the examples to be corrected so they conform to the chaining rules as described in the https://docs.cypress.io/api/table-of-contents documentation.

from cypress-example-kitchensink.

Unfortunately I'm unable to provide a PR to resolve this issue, which remains unaddressed.

Steps to reproduce

Comment out

and then execute

npm run lint

shows

✖ 57 problems (57 errors, 0 warnings)

from cypress-example-kitchensink.

+1

from cypress-example-kitchensink.

@MikeMcC399 I'd be fine with an update to the example recipes to reflect our new conventions. We just never revisited this.

from cypress-example-kitchensink.

• Thanks to @rubysolo for addressing this issue in #802 !

from cypress-example-kitchensink.

🎉 This issue has been resolved in version 2.0.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from cypress-example-kitchensink.