cyim12 / idm221-ccy29 Goto Github PK

Attribute values should be in double quotes.

https://github.com/cyim12/IDM221-ccy29/blob/f4a529754e05784b4c74071c98bc611340cbda84/index.html#L13

This should be fixed on every HTML page.

Code Quality

• Capital letters in file/folder names goes against best practices
• Single quotes for attribute values should be double quotes (#1)
• Repetition in CSS file should be refactored

Functionality

• Images in the portfolio section should be JPEG format, not PNG.
• Portfolio page subnav needs an indicator to tell the user which page they're currently on.

Design

• Portfolio section spacing could be done better to allow the images to display larger.
• Inconsistent spacing and positioning throughout.
• Homepage is begging for some design love. The page feels like an afterthought.

---

An okay start, much of this project feels rushed on not fully thought out. You have pleasing typeface combinations and a nice color scheme, but you lack consistency in sizing and positioning which makes the finished piece feel unpolished. I think you could benefit from some high fidelity wireframes early on in a redesign. I look forward to what you come up with next term.