cxwudi / niconico-video-downloader Goto Github PK

As indecate in title, we need a warpper class that can manage the driver, and move login(), setup() and reset() functionality into this class. Afterward, replace all driver attributes in each classes with this warpper.

using sqlite to store all vsong information, and filesystem manager class that corresponds to rename a video, move a video file, or even delete a video file

Niconico has completely updated its favorite list websites, probably all elements are changed.
Code that related to reading favourite list need to be updated correspondingly.

The declearation of TreeSet task and done should not be the concrete class, it should be the interface Set, change it globally

Should reduce the size of the test files, 97MB is a bit excessive.

should use the common configuration library.
when maven generates resource runs, the following happens:

• run a java class that writes selenium driver path into the system_config.property file

when the main project runs:

• let a static block run to setup selenium system property
• everytime project use getXXX() function to get a constant variable
• getXXX():
  • First check if the constant variable has been created, if yes, return it
  • if not, use common configuration code to read variables from system_config.property file and save it into a constant variable

Instead of writing a list of alternatives in the readme, just create a new repo dedicated to it.
And redirect users who saw this repo to the new repo with more info

New feature:

• use system_config.property and user.property to define constant variables in the niconico downloader
  • that means you can use your own account, set where to download, and use what method to download and etc.

Design diagram:

• See Onenote

And also don't forget the update the README.md file

Task needs to record the output file, the video URL, (not the direct video URL) that youtube-dl need to used
VideoDownloader contains a bunch of code for figuring out the output file and createing directories. Move these code to a new class and change the downloadUsingYoutube-dl() to receive a Task instance

two possible reasons, either the try-on-resource statement is having problem, or the niconico's server is unstable. for now we have already roll back to VideoDownloader.java to original version, but the investigation is still needed

use maven exec plugin and we move it by ourself, using Apache Common IO

It has shown that a few videos got nm-ID instead of sm-ID. Our Vsong class assume that all ID are sm-ID, that's wrong. Change the field smId back to id. And the type declaration of new field id should be String instead of int. New field also should record the whole id like smXXXXXX, nmXXXXXX, instead of just numbers XXXXXX.

Also, since the field is changed, don't forget do others necessary code change in the whole project to make thing compiles.