Comments (8)
Thanks for reporting! Would you please try branch issue304
@ 5f62e0a and confirm the issue is resolved? I don't have a good repro for onTabReplaced handy :) . Much appreciated!
from tabfern.
I'm now running 0.3.1.1 in parallel. I'll know if it works properly in a few hours.
Edit: One of the computers I'm using has only 2G of ram. It's not a problem with the old win7. And with ublock running in my browsers the webpages are much lighter. So the browser is still perfectly functionnal. It starts swapping when I reach 15-20 tabs (or less if they are big pages).
from tabfern.
The fix works. I don't have orphaned tabs left in TF list.
But there is still the second error. I've launched chrome with TF 0.3.0 and 0.3.1.1 and looked at the dev tools. Then I opened as many sites as needed to trigger a tabReplace. What I could see is that for every error in 0.3.0 I can see an error in 0.3.1.1
in 0.3.0
Error in event handler: ReferenceError: addedTabID is not defined
at onTabReplaced (chrome-extension://oflhofndbpjhlfnkbclmfkchpnkghflg/win/main.js:37839:42)
in 0.3.1.1:
Error in event handler: ReferenceError: tab_val is not defined
at onTabReplaced (chrome-extension://oflhofndbpjhlfnkbclmfkchpnkghflg/win/main.js:37844:75)
from tabfern.
Sorry --- missed that second item (now marked "Item 2") when I read your initial report! Fixed in force-pushed issue304
, now 0.3.1.2. Please let me know if the issue is fixed at 98e8924. I tested the changes by manually invoking the onTabReplaced()
function and it at least runs to completion :) . Thanks!
from tabfern.
I can confirm. Comparing side by side:
No more errors. No orphaned tabs in the list. Looks good. :)
from tabfern.
@Procyon-b Much appreciated! Will release shortly.
from tabfern.
0.3.1 submitted for Google review --- will tag when it is released.
from tabfern.
It's released. :)
from tabfern.
Related Issues (20)
- Support Nested Tabs (like Tabs Outliner) HOT 1
- /
- Automatically open windows at startup HOT 1
- [Feature Request] Expanding on #91 to allow dragging the root node from the TabFern GUI panel to an external app HOT 1
- Minimise, maximise and close with chrome HOT 4
- Feature Request: Open Only Selected Tabs in a Window HOT 1
- Feature Request: Search bar HOT 1
- Closing a single tab that is playing audio doesn't prompt for confirmation
- Remove S.ISSUE35
- After closing and opening the TF list window issue HOT 2
- When keyboard shortcut is _not_ set, Ctrl+Shift+T opens a new TF window HOT 1
- Hotkey for "Add/edit a note for the current tab"
- enable adding borders to top level HOT 3
- out of date limits page on tabfern webpage HOT 2
- On Chromium with very long Window Titles - backup does not work HOT 3
- ability to add new tab to remembered window
- Option to remember tabs automatically on a schedule HOT 12
- Search among the saved tabs for duplicates, and delete them
- Forbid "forget" in a partially-open window
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tabfern.