Windows as children of windows, &c. Requested by Blank Makkara via user review 2017/09/07.

Edit Also requested by Terrn Lister via support request 2018/11/17.

Include at least:

• Basic functions (rename, close, delete)
• Zooming (Ctl+plus and Ctl+minus)
• Getting help

• Add them
• Decide what to put in them

@r4j4h, currently, in fcfa1e4, I get the "no shortcut driver" path. I then observe that shift+right click never unlatches. I added a console.log and it appears that the win.onkeyup here is never being called (perhaps the browser-provided context menu is eating it?).

• Would it make sense to use addEventListener instead of the direct win.on* assignments?
• Would you please check the non-driver path? Perhaps I am missing a component you have on your development machine. Which path do you get?
• Would you please rebase on master when you have a chance?

Feature requests (perhaps a separate, later PR than the above?):

• Would you be willing to add Shift+F10 as a hotkey to pop up the context menu, for the benefit of keyboard users?
• Would you add keyboard nav of the context menu itself? Currently, the context menu does not take keyboard focus, so it cannot be navigated with arrow keys and Enter.

(Note to self: the options check is not fully implemented per this)

• When opening a window for the first time, given that the user hasn't saved size and position (since #5 hasn't been implemented yet), open using the default size and a reasonable default position. See this SO question.

• (Edit moved to #141) Whenever opening a TabFern window, check the active monitors and make sure the new window is entirely (or at least partly) visible on screen!

Hi there! Thanks for starting this.

In my fork I have started adding a Right-click menu, with corresponding Option to toggle on and off, and in a separate, related branch I started added Keyboard Shortcuts, also with a toggle and ideally a keybind customization menu panel in the future.

I want to open a PR now, but I have some concerns I want to address so that I can clean things up appropriately for a proper PR.

1. I used SASS. It's light, so I can totally clean up a MR that is SASS-less, but ideally we would want a build chain to convert them to CSS, and that means development dependencies. So I wanted to see how you felt build chains.

2. New dependencies. In the Keyboard Shortcuts branch I brought in Keypress to help, but I also kept all the usage of the library into one "driver" class so it's fairly easily to incorporate a different solution. Possibly jQuery or mootools based since those are already there, or something else, if you have a preference?

@r4j4h Would you be willing to look at this one? Add a user option to control whether the TabFern window has a horizontal scrollbar or not. Requested by Blank Makkara via user review 2017/09/07.

Also related to #31.

Need the ability to add some type of divider between tabs, especially in long tab lists.

@r4j4h would you please take this one?

See also discussion in #1.

• Add a webpack v2 build script that builds into /dist. Assume node/npm/webpack are installed.
• Document toolchain-installation and building instructions, perhaps in /HACKING.md or some such.

For now, please do not minify, and please use non-minified libraries. I would like to introduce minification later, probably in v1.0 or v1.1.

After some more testing based in this, I am planning to manually update /webstore from /dist whenever I update the version on the Chrome Web Store. That way we won't have to manually skip-worktree new files in /dist, but the actual running source will still be available to browse online.

• Automatically store copies of the current save data on a schedule. Weekly/monthly, perhaps?
• User option to disable the capture of backups
• UI to delete specific backups, or all backups
• UI to view and restore backups

Requested by a user via email 2017/10/25.
Requested by Mike Gordon via review 2019-01-27.

Changing from one Chrome window directly to another:

Focus change from 17 to 47; lastfocused 47
view.js:1217 Tab activated:
view.js:1218 {tabId: 27, windowId: 17}

But going the other way:

view.js:1064 Focus change from 47 to -1; lastfocused 17
view.js:1064 Focus change from 17 to 17; lastfocused 17

That intermediate -1 throws us off.

This was a TO feature I used frequently, and I would like to see it in TabFern. A tree item, instead of being a link to a tab, can be a horizontal rule or other visual divider.

Apparently, the normal close processing doesn't happen when the browser is shutting down. See pertinent bug report. Observed in v0.1.7.

Because it would be a nice feature to have. Probably on the hamburger menu; maybe also as a toast.

onResize doesn't fire when the popup moves, so we don't save position unless the size also changes.

Possibility: use a setInterval callback to check if the position has changed every n seconds, and save if so.

Are there any other double-click actions of interest?

Requested by LateNightHacks via user review 2017/10/14.

Note: looks fairly straightforward

• Test runner
• Unit tests
• Regression tests

Depends on #4.

• Export because it's a Good Thing
• Import in case you switch machines
• bonus Import from Tabs Outliner, because I have a lot of saved windows! --- moved to #27

• Save the timestamp a window was last opened (closed?)
• Sort option by timestamp asc
• Sort option by timestamp desc

• Context-menu item to move a window to the top
  • setting to determine whether to scroll there?
• Setting to move a closed window to the top when you reopen it
  • Note: this already exists for new windows, e.g., created with Ctl+N. The corresponding function could be provided for reopening saved, closed windows.

My tree is getting long enough that I think these might help.

Including moving closed tabs between windows. Requested by Blank Makkara via user review 2017/09/07.

I would also add the ability to create a new window - e.g., drag a tab's node out of the tree to create a new window to hold that tab (open window for open tabs; closed window for closed tabs).

• Close all saved windows
• Close and save all windows
• Close saved windows; delete unsaved windows

Handy for larger trees, to save scrolling if you just want to clear the decks and start fresh.

Probably a submenu with those options, rather than individual menu options.

What to show? Number of windows? tabs? Number open? saved? Requested by Blank Makkara via user review 2017/09/07.

Edit As of 2019-09-26, the former issue35 branch is now master!

Ability to open or close one tab at a time, rather than having to do the entire window at once. Requested by Blank Makkara via user review 2017/09/07.

Known issues

Bugs

• The tests are hard to read and hard to modify. I need to write a better skeleton so that I can easily write tests expressing the semantics I want.
• Given tabs open 1, closed 2, open 3, open 4, drop 4 before 3. It snaps to after 1 rather than staying where you dropped it.
• When behaviour like that happens, and then you middle-click to open a new tab from a tab that is not the rightmost, the mapping of indices to windows is thrown off.
• Moved to #280
• Need to finish implementing collapse option from 25752b3 - Edit will not be implemented at this time- see 2deb068
• Moved to #281
• In a partially-open window, drag an open tab (in the browser window) from after a gap to before, and then back. Sometimes the tab's tree entry will skip a closed tab, then jump to after two open tabs, when moving from left to right back across the gap. Edit We now have well-defined behaviour for this case. The tab will stay on the same side of the gap until it has to jump.

Design questions

• Moved to #282
• Moved to #283

Easy to add, and some users might find it helpful.

because the a.jstree-anchor and the div.tf-action-group are not children of the div.jstree-wholerow, so mouseenter and mouseleave trigger when the mouse moves on and off of the a text and the div icons.

Show the vertical/horizontal lines.
Requested by LateNightHacks via user review 2017/10/14.

Because I use one multiple times a day, and I have TabFern open the entire time I'm logged on. This is my current favorite.

Actually, I have been thinking about adding a hamburger menu at the bottom, since the transparent overlay in Tabs Outliner has tripped me up in the past. A menu would be a good place for a tea timer, since it wouldn't get in anyone else's way.

I prefer not saving window size/position since I may use the same set of tabs for different tasks with different window layouts. However, another option is to save size/position. Add an option to do so, and sensible handling if the user enables and later disables the option. If the option is disabled, should previously-saved windows re-open in their saved locations anyway?

Suggested by Mayken in a comment to this SO question.

One click on a window and all of its tabs open, which can be slow if you have lots of tabs in that window. Add a configuration option n so that if a window has more than n tabs, on click, it will ask "are you sure?" before opening. n=0 => no limit. Default to 31 because it's a nice round number :) .
Noted by Blank Makkara via user review 2017/09/07

After fixing #47 in bb4316c, sometimes, when focus is not on the TabFern window, a click on an action button will not register as on the button, but instead as on the node itself.

As far as I can tell, the node is being dehovered briefly during the focus change. That dehover causes the action buttons to disappear, which in turn causes the click to land on the div.jstree-wholerow, whence node selection.

As a side note, don't un-highlight the currently-focused tab/window when focus hits the popup because you are clicking on another tree item.

The new functionality of moving tabs within a window by drag'n'drop works fine. But there's a small bug:
if currently active tab (highlighted in bold text) is moved by drag'n'drop, the bold text is lost and does not recover after focus is returned to the active window.

More precisely:
If focus is moved to TabFern window, the active tab highlight (bold text) is lost, which is understandable.
But after focus is returned from TabFern window to Chrome (back to the tab that was active before clicking at TabFern window), the active tab highlight does not return, only the active window is highlighted with bold text.

It recovers after some other tab is activated.

Keep things cleaner visually. This should also open the way to per-tab actions.

I am working on this in the action-groups branch.

because I have a lot of saved windows!

Turns out you can open a new one with "open in new tab" - coordinate those through background.js.

Use the first frame to reduce visual distraction. E.g., per this. Manually setting img.src to a data URL does appear to work in Chrome 60.0.3112.101.

You can already rename a window's tree entry to whatever you want. Add a similar function to permit adding text notes to the tree entries representing tabs.

• Split the TabFern window and load a plugin's page in an iframe
• Receive and respond to requests from other extensions for a two-way communication (e.g., #7)
• Store and forward settings based on extension ID
• Present plugin settings in the TabFern window
• Give plugins an entry in the hamburger menu
  • When the menu item is selected, send a message to the other extension
  • Permit plugins to add custom sort orders to the Sort submenu (needs a Promise-aware Array.sort? Firefox sort, in C / V8 sort, in JS with natives)

If Chrome is restarted due to an update (regardless of setting "Pages to open on startup" that is set to "Open the New Tab page"), Chrome helpfully re-opens the windows that were open before restart.

But TabFern then naturally creates duplicate windows for all the windows that were re-opened by Chrome.

Could it perhaps be possible to test if a window has exactly same tabs than already existing window in TabFern and then not create a new window with the same tabs as before?
I'm not sure if there's a way to test if Chrome was just restarted, but if there is then it might be even better to take that too into account when checking whether to re-use the old windows in TabFern instead of creating new ones.

Currently after Chrome restart the easiest option is to delete all windows that were open before the restart and rename the newly created windows back to the same names as the windows before restart.

• A-Z
• Z-A
• 0-9
• 9-0

Any other orders?

• Function to collect all open tabs from all open, unsaved windows into a single window. I discovered this when I just realized I have about 15 windows open, each with only one or two tabs.
• Right-click menu function to sort open tabs within a given window

Permits you to rename a window only for the current session, without saving it.

This should be pretty easy - if any windows in the save data are isOpen && !iskeep when TabFern starts up, those were crashed windows.

This is because tabOnRemoved doesn't update the indices.

E.g., next to the icon.

• window.performance may require content scripts. I am trying to avoid those if possible.
• chrome:system scraping looks promising, but when I try to XHR it, I get Not allowed to load local resource: chrome://system/.

Requested by LateNightHacks via user review 2017/10/14.

@r4j4h Following on from #8, which was merged in the course of the push to v0.1.
Besides the TODO item there, the other thing I would appreciate along with the code is a bit more documentation. At this point, the options and the default bindings don't look to me like they would tell a new user what the shortcuts were for. Thanks!