is there something broken with the following trigger as stability_cost_to_declare_war shows as error in 00_diplomatic_actions.txt and it is correctly included in modifiers. Is the #todo still todo?

scope = country

###Returns true if the value of the specified modifier is at least X for the country.
alias[trigger:has_global_modifier_value] = {
which = enum[modifiers] #todo
value = float
## cardinality = 0..1

extra_shortcut = bool

}

1. Inside of scripted effect with params u can export these params to variables:

export_to_variable = { 
                 which = hex_num_of_quest_provinces 
                 value = $amount$ 
 }

2. On province scope u can export culture to variables.

Probably some other things too, but these are the ones I found.

Example government file:

imperium_of_mann_reform = {
	icon = imperium_mann
	allow_normal_conversion = no
	lock_level_when_selected = yes
	allow_convert = no
	fixed_rank = 3
	potential = {
		has_country_flag = imperium_mann_flag
	}
	valid_for_nation_designer = no

	modifiers = {
		global_unrest = -2
		max_absolutism = 10
		monarch_military_power = 2
		cav_to_inf_ratio = 0.5
	}
	
	custom_attributes = {
		locked_government_type = yes
	}

	conditional = {
		allow = { has_dlc = "Third Rome" }
		claim_states = yes
	}
}

The file in the cwtools-rule is common/government_and_reforms

In the common naval doctrines file the can select section appears to be correctly set to be scope country in the 00_small_types_consolidated.cwt file. Therefore culture_group = or primary_culture = should work and culture = should be flagged as an error. The issue is that culture = is not flagged as an error and I can not figure out why. Would appreciate if anyone can point out why. Thanks

Straight forward, as the title says. See image if confused.

Anbennar seems to have a more compact way to write check_variable and others:

REB = { check_variable = { nbExpedition = 1 } }

No which, no value. I guess it's working, so maybe it's smth worth checking.

As you can see, province IDs are quite problematic according to CW Tools. These are all perfectly functional provinces, as far as the game is concerned.

The corresponding error when I hover one of them (appears in the output window)
[Info - 11:52:22 PM] symbolInfoAtPos common/colonial_regions/00_colonial_regions.txt c:\Users\theol\Documents\Paradox Interactive\Europa Universalis IV\mod\Elder-Scrolls-Universalis\common\colonial_regions\00_colonial_regions.txt Looking for effect "1551" in the 1436 effects loaded

When I hover the provinces entry, it gives this error:

So it seems to not think that those are province_id types, but rather effects. Very puzzling to me. Hopefully someone knows what's up haha.

cwtools doesnt register "removed_effect" in a specific ides (not in the entire group) as correct

Straight forward, as the title says. See images if confused.

Ideas are not treated as COUNTRY scope, allowing one to use province-level ideas.

For example in this piece of code, the idea ser_second has the wrong modifier, it needs the "global_" prefix.

SER_ideas = {
    start = {
    	land_morale = 0.10
    	manpower_recovery_speed = 0.15
    }
    
    bonus = {
    	discipline = 0.05    
    }
    
    trigger = {
        tag = SER
    }
    free = yes            #will be added at load.
    
    ser_first = {
    	fort_maintenance_modifier = -0.2 
    }
    ser_second = {
		trade_goods_size_modifier = 0.1
    }
    ser_third = {
    	cavalry_power = 0.1
    	morale_damage = 0.1 #or let them recruit winged hussars if feeling spicy
    }
    ser_fourth = {
    	ae_impact = -0.1
    }
    ser_fifth = {
    	idea_cost = -0.1
    }
    ser_sixth = {
    	leader_land_shock = 1
    }
    ser_seventh = {
    	diplomatic_reputation = 1
    }
}

owned_by = overlord in province expect country

paradox bug or cwtools fix?????

line 150 add_mercantilism = 2 wrong scope per cwtools in province expect country

paradox bug or cwtools fix????

The following code complains that $effect$ is not valid in while = { },

for = {
  set_variable = {
    which = ForLoopCounter
    value = $amount$
  }

  while = {
    limit = {
      check_variable = {
        which = ForLoopCounter
        value = 1
      }
    }
    $effect$
    subtract_variable = {
      which = ForLoopCounter
      value = 1
    }
  }
}

All usages of it in the mod are for = { amount = X effect = "code that does effect here" }

More options are used as which in has_global_modifier_value in Anbennar. Probably all are working, cause they are used everywhere (224 errors total)

num_accepted_cultures
movement_speed
fire_damage
shock_damage
trade_efficiency
local_build_time
global_missionary_strength
local_development_cost
global_spy_defence
global_ship_trade_power
local_institution_spread
global_manpower
spy_offence
trade_steering
prestige
tolerance_own
siege_ability

1.1. The government_reform field can have regular reforms too, not just basic ones.
1.2. Which also makes it wrong to split it in subtypes by looking for this field. So maybe it's better not to have subtypes? Dunno if u want to preserve forced cardinality on default subtype (which is also not really required).

2 Trigger is optional, especially if u put the reform in government_reform field

I am using defined_text = { name = X } in customizable_localisation and it would be nice if it recognized those keys

is_city = no is unexpected apparently

religion_enforced = no is unexpected in allow

Not sure why this error is showing now when it was not part of the new patch - ?????

tooltip = {
add_province_modifier = {
name = lit_centers_urbanization_modifier
duration = 7300
}
}

complains it is in the wrong scope is country expect province - not sure if bug or cwtools problem

I posted this issue on the main cwtools, but maybe I should have done it here:

cwtools/cwtools#33

Hello, I went through a serious of modifiers and conditions that are unexpected by the extension, whereas the game process it correctly, I will post only one photo to show you what I mean:

1. movement_speed_onto_off_boat_modifier
2. accept_vassalization_reasons
3. institution_growth
4. extra_manpower_at_religious_war = yes (I recall this working, although I may be wrong)

Conditions:

1. ADM/DIP/MIL (used to refer the current adm/dip/mil stat of the ruler)
2. has_adm_advisor_1/2/3 as well as has_dip_advisor_1/2/3 and has_mil_advisor_1/2/3

Effects:

1. join_all_offensive_wars_of = TAG
2. join_all_defensive_wars_of = TAG

if I'll ever find others I'll write them down :)

unrest (both province and global) can accept negative value

These are minor, but the last ones I have :)
Any way to fix them or is that unfixable? All from vanilla loc (EU4_l_english, text_l_english)

exile_consort_as and set_consort is marked as an error when used in if statements:

Scripted Effects parameters s giving an incorrect error (new_tag scopes to a country):

The config thinks has_country_flag and set_ruler is used in a province and trade node scope for some reason even though new_tag is a country scope:

Lastly, if is unexpected in new_tag for some reason:

File: missions/SCA_Polish_Missions.txt

trigger = {
  stability = 3 
  poland_region = {
    type = all 
    NOT = { unrest = 1 } 
    num_of_times_improved = 3 
    NOT = { average_home_autonomy = 5 }
  }
}

Reported to Paradox here

Was looking at vanilla /interface files and noticed a few warnings like this in social_view.gfx and core.gfx files.
Dunno if it's eu4 config or base CWTools issue. Just letting u know.

average_autonomy_above_min = 5

wrong scope is province expect country in two places

not sure if bug or cwtools

potential_on_load = {
NOT = { has_dlc = "Lions of the North" }
}

NOT is unexpected on potential_on_load in two places also same problem in LIT missions

U can create an effect with a conditional generic param like this:

hex_set_heir = { 
         [[chef] 
                 define_heir = { 
                         name = "Chef" 
                         dynasty = "'the Cauldron Master'" 
                         birth_date = 2.1.1 
                         claim = 50 
                 } 
         ]
}

And then use it it somewhere like

hex_set_heir = { chef = yes }

CW Tools marks it as error, but this seems to be a perfectly valid code.
Dunno if u accept issues that are not vanilla, but still working. Kinda not familiar how to code this, but I have a few other suggestions that I might be able to code.

Found this when looking through mod files for the mod "Anbennar",

According to https://eu4.paradoxwikis.com/Building_modding the building scope should allow an optional indestructible = <bool> tag which hints the game to exempt it from being removed during bankruptcy.

Currently cwtools gives CW262 for these.

As noted here PDX has provided a list of all modifiers in the game, we need to check if they are all present.

I used the following code to generate a list of the modifiers we don't have, from it we have to distinguish which ones are from 1.35, and which ones we are missing:

#!/bin/sh
while read -r modifier _ val; do
	rg -q -w "$modifier" modifiers.cwt || echo "$modifier = $val"
done

That are in 1.34:

• hussars_cost_modifier = 1 # No image and not localised
• reform_progress_growth_building = 1 # Appears as Reform Progress Contribution
• cb_on_government_enemies = yes
• extra_manpower_at_religious_war = yes
• reduced_native_attacks = yes
• no_cost_for_reinforcing = yes
• number_of_cannons_flagship = 1
• relation_with_other_culture = 1
• territories_governing_cost = 1
• monthly_heir_claim_increase_modifier = 1

That are in 1.35:

• can_claim_states = yes
• free_concentrate_development = yes
• monarch_power_tribute = 1
• tributary_conversion_cost_modifier = -1
• expand_infrastructure_cost_modifier = -1
• max_absolutism_effect = 0.1
• centralize_state_cost = -0.1
• local_centralize_state_cost = -0.1
• land_morale_constant = 1
• naval_morale_constant = 1
• max_general_shock = 1
• max_general_fire = 1
• max_general_maneuver = 1
• max_general_siege = 1
• max_admiral_shock = 1
• max_admiral_fire = 1
• max_admiral_maneuver = 1
• max_admiral_siege = 1
• coast_raid_range = 1
• development_cost_in_primary_culture = -0.1
• reduced_trade_penalty_on_non_main_tradenode = -0.1
• colony_cost_modifier = -0.1
• local_colony_cost_modifier = -0.1
• spy_action_cost_modifier = -0.1
• placed_merchant_power_modifier = 1
• reduced_liberty_desire_on_other_continent = -1
• overextension_impact_modifier = -0.1
• artillery_level_modifier = 1
• local_tolerance_of_heretics = 1
• local_tolerance_of_heathens = 1
• artillery_barrage_cost = -0.1
• annexation_relations_impact = -0.1
• vassal_naval_forcelimit_bonus = 0.1
• vassal_manpower_bonus = 0.1
• vassal_sailors_bonus = 1
• culture_conversion_time = 1
• local_culture_conversion_time = 1
• chance_to_inherit = 1
• global_allowed_num_of_manufactories = 1
• colony_development_boost = 1
• global_naval_engagement = 1
• immortal = yes #Dummy, doesn't do anything but has a cool icon I guess
• hussars_cost_modifier = 1
• garrison_damage = 1
• local_garrison_damage = 1
• assault_fort_cost_modifier = 1
• local_assault_fort_cost_modifier = 1
• assault_fort_ability = 1
• local_assault_fort_ability = 1
• same_religion_advisor_cost = 1
• can_revoke_parliament_seats = yes
• parliament_backing_chance = 1
• parliament_effect_duration = 1
• parliament_debate_duration = 1
• parliament_chance_of_decision = 1
• num_of_parliament_issues = 1
• max_possible_parliament_seats = 1
• reform_progress_growth_building = 1
• janissary_cost_modifier = 1
• allowed_tercio_fraction = 1
• amount_of_tercio = 1
• local_has_tercio = yes
• allowed_musketeer_fraction = 1
• amount_of_musketeers = 1
• local_has_musketeers = yes
• allowed_samurai_fraction = 1
• amount_of_samurai = 1
• local_has_samurai = yes
• allowed_geobukseon_fraction = 1
• amount_of_geobukseon = 1
• local_has_geobukseon = yes
• allowed_man_of_war_fraction = 1
• amount_of_man_of_war = 1
• local_has_man_of_war = yes
• allowed_galleon_fraction = 1
• amount_of_galleon = 1
• local_has_galleon = yes
• allowed_galleass_fraction = 1
• amount_of_galleass = 1
• local_has_galleass = yes
• allowed_caravel_fraction = 1
• amount_of_caravel = 1
• local_has_caravel = yes
• allowed_voc_indiamen_fraction = 1
• amount_of_voc_indiamen = 1
• local_has_voc_indiamen = yes
• can_recruit_janissaries = yes
• can_recruit_cawa = yes
• can_recruit_cossacks = yes
• can_recruit_rajputs = yes
• can_recruit_revolutionary_guards = yes
• allow_janissaries_from_own_faith = yes
• allow_mercenary_drill = yes
• merc_leader_army_tradition = 1
• merc_independent_from_trade_range = yes
• allow_mercenaries_to_split = yes
• may_not_reduce_inflation = yes
• may_not_convert_territories = yes
• enable_forced_march = yes
• number_of_cannons_modifier = 1
• heavy_ship_number_of_cannons_modifier = 1
• light_ship_number_of_cannons_modifier = 1
• galley_number_of_cannons_modifier = 1
• transport_number_of_cannons_modifier = 1
• hull_size = 1
• hull_size_modifier = 1
• heavy_ship_hull_size_modifier = 1
• light_ship_hull_size_modifier = 1
• galley_hull_size_modifier = 1
• transport_hull_size_modifier = 1
• engagement_cost = 1
• engagement_cost_modifier = 1
• special_unit_cost_modifier = 1
• special_unit_manpower_cost_modifier = 1
• number_of_cannons = 1
• max_flagships = 1
• ship_trade_power = 1
• ship_trade_power_modifier = 1
• can_transport_units = yes
• reverse_relation_with_same_religion = 1
• great_project_upgrade_time = 1
• local_great_project_upgrade_time = 1
• loyalty_change_on_revoked = 1
• estate_interaction_cooldown_modifier = 1
• all_estate_possible_privileges = 1
• warscore_from_battles_modifier = 1
• yearly_innovativeness = 1
• yearly_government_power = 1
• no_claim_cost_increasement = yes
• naval_morale_damage = 1
• naval_morale_damage_received = 1
• has_tercio = yes
• has_musketeer = yes
• has_samurai = yes
• has_geobukseon = yes
• has_man_of_war = yes
• has_galleon = yes
• has_galleass = yes
• has_caravel = yes
• has_voc_indiamen = yes
• has_streltsy = yes
• allowed_streltsy_fraction = 1
• amount_of_streltsy = 1
• local_has_streltsy = 1

Need to add to CWTools:

colonial_type_change_cost_modifier

colonial_subject_type_upgrade_cost_modifier

manpower_against_imperial_enemies