The cwtools-ck3-config from cwtools

First pass implementation for flavorization folder contents

Provide first pass implementation for the flavorization folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for combat_scenarios folder contents

Provide first pass implementation for the combat_scenarios folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

Open issues for tracking scope and prepare for contributions

Especially as more people start contributing, it'll be very helpful to document areas that need to be implemented. This should help new contributors easily see work that needs done, and hopefully prevent duplication of work. Initial issues will probably be for draft level completion that covers most common cases but maybe not complicated rules or full validation checks for difficult validations. In general, I'm expecting about 3 regular contributors, a smattering of people submitting PRs for rules that they write while working on their own mods (and who generally won't be closely updating progress on the tracker), people who just file issues for false positives/false negatives, and people who just want to track development and know whats implemented.

There are two main options that I can think of to track this:

Vanilla script passing. Progress is measured by getting vanilla files to properly validate with minimal false positives. This works as a concrete, tangible goal and is a good measure of project progress. Bonus points for finding legitimate vanilla bugs. Having a 'standard' set of files is helpful for keeping a standardized set of test cases, and guarantees an acceptable level of functionality for end users even if not all rules are implemented. This does run the issue however of some possible duplication of effort as getting files to validate might require dipping into tangentially related areas. This could possibly result in work duplication among core contributors if good communication isn't followed. This would more closely follow one-off contributions. It would require PR reviewers to fetch the branch and test it against the vanilla files.
.cwt completion. Track purely on the .cwt files and types that need a .cwt; combine sub-folders into a single issue. This keeps things isolated for better or for worse. It lacks the standardized test cases, and leads to very abstracted work that feels divorced from actual use. This doesn't seem like it would fit well with the workflow of that type of contributor, but would be easier to mark issues completed.

After typing it out, I'm very much leaning towards 1, and will probably implement things that way. Other than that, we should probably build out some issue infrastructure and repository QoL things.

First pass implementation for bookmark_portraits folder contents

Provide first pass implementation for the bookmark_portraits folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for effect_localization folder contents

Provide first pass implementation for the effect_localization folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for event_backgrounds folder contents

Provide first pass implementation for the event_backgrounds folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for ai_war_stances folder contents

Provide first pass implementation for the ai_war_stances folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

Refactor ai_values to use script_value instead

As per #1 , there is probably a more elegant way to encode the ai value enums to use the script_value type instead.

First pass implementation for console_groups folder contents

Provide first pass implementation for the console_groups folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for decisions folder contents

Provide first pass implementation for the decisions folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for activities folder contents

Provide first pass implementation for the activities folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

Possible upstream parsing bug

trigger_event is currently defined using the following union:

### triggers an event or on_action trigger_event = { id = X days/months/years = Y } (for events) or trigger_event = { on_action = X days/months/years = Y } (for on_actions) ...
alias[effect:trigger_event] = {
    id = <event>
    ## cardinality = 0..1
    enum[duration] = int
    ## cardinality = 0..1
    enum[duration] = {
        ## cardinality = 1..inf
        int
    }
}

...

alias[effect:trigger_event] = {
    on_action = <on_action>
    ## cardinality = 0..1
    enum[duration] = int
    ## cardinality = 0..1
    enum[duration] = {
        ## cardinality = 1..inf
        int
    }
}

The implementation in IR is similar.

However, on vanilla event files that use the id key, the parsing still expects on_action, and complains with a false positive. As far as I understand it, this union should work, so there's possibly either a bug with alias unions, or an undocumented limitation. Filing here for further diagnosis before filing an issue in the appropriate sub-project.

First pass implementation for dynasty_perks folder contents

Provide first pass implementation for the dynasty_perks folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for deathreasons folder contents

Provide first pass implementation for the deathreasons folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for dynasty_legacies folder contents

Provide first pass implementation for the dynasty_legacies folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for dynasty_house_mottos folder contents

Provide first pass implementation for the dynasty_house_mottos folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for courtier_guest_management folder contents

Provide first pass implementation for the courtier_guest_management folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

Value Field Rework

Possible numeric value types:

int/float: Only accepts the number itself, no variables, only @ links in the file itself.
int_static_field/static_field: Accept static variables too. It's mainly used for modifiers.
int_value_field/value_field: Accept scripted variables or can itself be a value field. Mainly used for effects.

The current value_field is what I called static_field, I'm not really sure about naming.
The last one currently has no real support. They are basically a special effect fields, which can have scopes and ifs, just the commands themselves are restricted to numeric operations.
It might worth it to make an universal framework for restricted effect fields, since there are places where only interface commands can be used.

Draft Core Implementation: effects

Effects are a core key type that are used in several scopes and are currently causing lots of false positives in events. Much work has been done already, but they need to be more fleshed out.

First pass implementation for dna_data folder contents

Provide first pass implementation for the dna_data folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for culture folder contents

Provide first pass implementation for the culture folder and the below listed sub-folders.

cultures
culture_names
eras
innovations

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

Refactor event themes from complex enum to type

As per #1 , refactor the event themes enum used in events.cwt to use types instead. This should be a simple change.

First pass implementation for coat_of_arms folder contents

Provide first pass implementation for the coat_of_arms folder and the below listed sub-folders.

coat_of_arms
options
template_lists

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for dynasty_house_motto_inserts folder contents

Provide first pass implementation for the dynasty_house_motto_inserts folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

Draft core Implementation: Triggers

Triggers are a core block used in several scopes and are causing false positives in many areas. A lot of work has been done on this, but a good complete draft implementation of them would significantly help practical usability of cwtools for ck3.

First pass implementation for achievements folder contents

Provide first pass implementation for the achievements folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for customizable_localization folder contents

Provide first pass implementation for the customizable_localization folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for casus_belli_types folder contents

Provide first pass implementation for the casus_belli_types folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for bookmarks folder contents

Provide first pass implementation for the bookmarks folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for dynasties

Provide first pass implementation for all dynasty related folders. This includes:

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

First pass implementation for character_interactions folder contents

Provide first pass implementation for the character_interactions folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for combat_effects folder contents

Provide first pass implementation for the combat_effects folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for focuses folder contents

Provide first pass implementation for the focuses folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for character_interaction_categories folder contents

Provide first pass implementation for the character_interaction_categories folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for ethnicities folder contents

Provide first pass implementation for the ethnicities folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for event_themes folder contents

Provide first pass implementation for the event_themes folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for ai_goaltypes folder contents

Provide first pass implementation for the ai_goaltypes folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

Refactor: move common used aliases to alias.cwt and remove duplicates.

As title. There are several aliases that are defined in a narrowly scoped file but are used across a variety of definitions. This makes it difficult to check at a glance what the aliases for complex descriptions are for example.

Off the top of my head, triggers, complex descriptions, and weight blocks are used in multiple places, but are in specific files at the moment.

Complex aliases used across many definitions could possibly be moved into an aliases subfolder as well.

Finish draft implementation of bookmarks.cwt

bookmarks.cwt seems largely complete, but needs behavior confirmation on several keys and verification against vanilla files. Contains the following todos. Issue will be considered resolved when important todos are resolved and vanilla files parse without false positives (excluding missing core dependencies). Remaining todos can be spun off into new issues as necessary.

First pass implementation for council_tasks folder contents

Provide first pass implementation for the council_tasks folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

Complex Descriptions defined multiple times

L15 of traits.cwt:

single_alias[complex_desc] = {
    ## cardinality = 0..inf
    desc = localisation

    ## cardinality = 0..inf
    random_valid = {
        ## cardinality = 2..inf
        desc = localisation
    }

    ## cardinality = 0..inf
    first_valid = {
        ## cardinality = 1..inf
        triggered_desc = {
            desc = localisation
            trigger = {
                ## cardinality = 1..inf
                alias_name[trigger] = alias_match_left[trigger]
            }
        }
        # This should probably be recursive in some way
        ## cardinality = 0..inf
        desc = localisation
    }
}

L40 of events.cwt

single_alias[complex_event_desc] = {
    ## cardinality = 0..inf
    desc = localisation

    ## cardinality = 0..inf
    random_valid = {
        ## cardinality = 2..inf
        desc = localisation
    }

    ## cardinality = 0..inf
    first_valid = {
        ## cardinality = 1..inf
        triggered_desc = {
            desc = localisation
            trigger = {
                ## cardinality = 1..inf
                alias_name[trigger] = alias_match_left[trigger]
            }
        }
    }
}

These should be refactored into a single alias.

First pass implementation for dynasty_houses folder contents

Provide first pass implementation for the dynasty_houses folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for casus_belli_groups folder contents

Provide first pass implementation for the casus_belli_groups folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

Organize and triage code TODOs into github issue

There are a lot of todos in code without a lot of external visibility unless actively searching from them. It would behoove us to move them to a more visible spot on github to track them in one place. Checked box means the item has either been addressed in code or documented on the issue tracker.

Determine if same_opinion_if_same_faith should be added to modifiers.cwt

From discord:

[10:45 AM] Zonr_0: There's also what seems to be a missing modifier
[10:46 AM] Zonr_0: that I see no reason why it shouldn't be in [modifiers.cwt]
[10:46 AM] Zonr_0: same_opinion_if_same_faith
[10:46 AM] Dayshine: Used in one place, not in docs
[10:46 AM] Dayshine: Hmmm
[10:46 AM] Dayshine: 50/50 it's an error
[10:47 AM] Dayshine: It's also not in the localisation, so would show up weirdly
[10:49 AM] Zonr_0: Yeah, thats partially what I'm leaning to, but after parsing it, I can see it distinct from same_faith_opinion
[10:49 AM] Zonr_0: but I could also see it as a typo too
[10:49 AM] Dayshine: Easiest thing to do is just...
[10:49 AM] Dayshine: Try it ingame :P
[10:49 AM] Zonr_0: I'll flag it as an issue in github and test/fix it later.

First pass implementation for defines folder contents

Provide first pass implementation for the defines folder and the below listed sub-folders.

ai
audio
graphic
jomini

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for character_backgrounds folder contents

Provide first pass implementation for the character_backgrounds folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for buildings folder contents

Provide first pass implementation for the buildings folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for factions folder contents

Provide first pass implementation for the factions folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

First pass implementation for council_positions folder contents

Provide first pass implementation for the council_positions folder.

First pass implementation means that all (valid) keys used in vanilla files either:

Have full working implementations OR
Have working placeholder implementations (eg. simple scalars) with status documented on the tracker OR
Have false positives in a placeholder or incomplete implementation that properly covers the majority of use cases. OR
Have false positives or are unimplementable due to bugs or missing features in cwtools core

Additionally, before this issue can be closed, please make sure of the following:

All significant TODO items are documented in the issue tracker
Documentation strings are either present or documented as missing in the tracker

That being said, these are just the criteria for this issue and scope item to be considered finished. In these early days, every new definition is incredibly helpful for end users trying to use cwtools! PRs with partial implementations are more than welcome!

This is an auto-generated issue. It may make sense to close this ticket, combine it with others, or split it into smaller chunks.

cwtools / cwtools-ck3-config Goto Github PK

cwtools-ck3-config's Introduction

cwtools

Projects that use CW Tools

Stellaris tech tree: https://github.com/draconas1/stellaris-tech-tree

SC Mod Manager: https://github.com/WojciechKrysiak/SCModManager/tree/feature/PortToAvalonia/PDXModLib/Utility

Example usage (C#)

cwtools-ck3-config's People

Contributors

Stargazers

Watchers

Forkers

cwtools-ck3-config's Issues

Recommend Projects

Recommend Topics

Recommend Org