curlysemi / diary Goto Github PK

It occurs to me that a user might want to create a whole class of entries for the same 'diaries' (if that makes sense) and retyping the passwords every single time could get very frustrating very quickly. Additionally, if we are to actually take the password route, the passwords need confirmation fields, because it wouldn't be a good user experience if they happened to mistype their intended password.

While the existing base functionality makes sense for a single-entry system, we should consider other use-cases and attempt to support them, especially as it doesn't seem to be too difficult.

While diary is the name of the application, users could define "journals" that entries are intended for. That way, the user could simply pick the journal each entry is intended for without having to type passwords (and without the convenience of lazy, bad passwords).

Achieving this does require asymmetric cryptography, but I don't think that's too terrible of a trade-off. It would be a fairly simple use of ECDH to arrive upon the key to use with ChaCha20. We'd just need to also include the ephemeral public key(s?) with the entry.

One of the messages for an entry caused the entry to fail during the attempted save:

Exception in Tkinter callback
Traceback (most recent call last):
  File "/usr/lib/python2.7/lib-tk/Tkinter.py", line 1540, in __call__
    return self.func(*args)
  File "./diary.py", line 50, in save_command
    entry = diary_io.create_entry(message_password_pairs)
  File "/home/julian/Documents/diary/diary_io.py", line 32, in create_entry
    encrypted_entry_data = diary_util.enc(messages, passwords, index=index)
  File "/home/julian/Documents/diary/lib/utils/diary_util.py", line 45, in enc
    plaintext = encoder.encode(plaintext)
  File "/home/julian/Documents/diary/lib/models/pkcs7encoder.py", line 39, in encode
    encoded = binascii.unhexlify(output.getvalue())
TypeError: Odd-length string

I added a space to one of the entries and it was able to save. I'll need to come up with a minimal example, but I'm creating the issue to track this bug.