Giter Club home page Giter Club logo

Comments (4)

cubenicke avatar cubenicke commented on June 12, 2024 1

Moving overpower won't solve the issue that it casts op during execute phase, this since execute requires more rage than op. Add this condition to Overpower:
and (UnitHealth("target") / UnitHealthMax("target") * 100) > 20
It considers Tactical Mastery so the first caculation is correct. If You have tactical 5/5 and tactical rage waste set to 25 (/fury dance 25) it will allow stance dance at max 50 rage.

from fury.

cubenicke avatar cubenicke commented on June 12, 2024

Hi!

Overpower is done when you have enough rage to do it and that stance swap won't waste more rage than set limit. Currently Overpower doesn't check flurry or availability of other abilities.

Current priority:
Execute
Overpower
Bloodthirst/Mortal Strike
Whirlwind
Hamstring if no flurry and all the above are on CD and above x rage
Heroic Strike (only if rage over “x” value and if all the above are on cooldown)

Good input, the logic have possibilities for improvement.

from fury.

macropusher avatar macropusher commented on June 12, 2024

Thanks for explaining the prio - it seems that overpower sometimes even happens during the execute phase -
Would it be possible to place overpower priority below whirlwind in the current order?

Or maybe I could just move the overpower line in the lua of my copy to below hamstring?

Regarding the stance swap rage waste parameter-

Does it take into account how many Points you have in tactical mastery?
For example; if I set /fury stance 25- does that mean that if I had 50 rage, it would waste 25 rage , leaving me with 25 (due to tactical mastery)

OR
Does it assume 0/5 tactical mastery, so it would stance swap only at 25 rage- and assume that I’m gonna lose that 25 rage? (I would in fact keep the 25 rage due to tactical mastery at 5/5)

from fury.

macropusher avatar macropusher commented on June 12, 2024

Thanks for your response as always Cubenicke :) very much appreciated.

Aha that explains why overpower was happening during execute phase- you definitely don’t want that happening! It’s a significant dps loss compared to execute spam.
I will add that condition to the overpower script in the Lua.

Ah damn so I’ve been wasting 25 rage every overpower! :( I will change it to ( /fury dance 0) then so it only changes to battle stance at 25 rage or less.

Many thanks!

from fury.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.