cubecart / v6 Goto Github PK

With respect to:
cubecart/v5@26134c4
In CC6, getAddresses() needs fixed while getDefaultAddress() is fine
In CC5, getAddresses() is fine while getDefaultAddress() needs fixed

With respect to:
https://github.com/cubecart/v5.2.14/issues/117
The call made in cart.class.php, line 240 (and the same issue still exists in CC5) sends $options_identifier_string to Catalogue->getProductData() in the wrong argument position.

Perhaps this has escaped causing problems so far, but the potential exists.

Intentionally deleted, missing, or moved?

e.g. Add "Shipping", Payment Etc..

Intentionally deleted, missing, moved?

as above in Admin, GitHub link in forum, too

Code needs to be added to prevent non image file being passed into the GD class.

Very similar to #20, if there is a style in Session or Config, it won't be available.

GUI->_setStyle() globs for a /styles/ folder which isn't there for /foundation/.

Eventually, SKIN_SUBSET is empty.

But I read the directory structure as implying that 'default' is a valid subset.

Name of language and abbreviation overlaps flag.

Install sets language as en-US but the language file is en-GB. This breaks the front end until settings have been saved.

When you add to basket a product with a required option - you get a warning that you have to select from the dropdown menu (in my test it said £50 yes please). Then select the option (as advised) and go to checkout. You will find the number of products listed in the cart is 2,

The problem is that if a customer sees a red warning box for a required option they aren't going to expect the 'failed' click to place anything into the cart.

Similar to #16, if upgrading from CC5 to CC6, the existing config settings will be used.

So, there may also be an issue with no valid skin to use ("Last ditch skin" - GUI line 1330).

Session may have a client skin, but (I cleared cookies and changed ini_set('session.name', 'HTDOCSCC600B1'); maybe not. Then Config may have a skin, but it won't be in $this->_skins. Finally, if $this->_skins does exist, the first skin found in the skins folder will be used.

Suggest that foundation always be the last ditch skin and do not trigger_error().

Intentionally deleted, missing?

The icon to switch between Enabled and Disabled for each language on the list of languages won't switch.

In /skins/foundation/css/cubecart.common.css, line 3, there is:
font-size: 1.375rem;
rem is not valid.

See also cubecart.css, line 138.

And plenty of occasions in foundation.css and foundation.min.css.

$find   = array("latin1", $table['Name']);
$replace  = array("utf8 COLLATE utf8_unicode_ci", $table['Name'].'_utf8');

$db->misc(str_replace($find, $replace, $schema[0]['Create Table']));

This is going to break if the "Create Table" SQL already has a collation statement!

After a fresh installation the frontend is blank. System Errors within Admin CP shows:

"/classes/language.class.php:93 - No valid language found!"

I've checked which language is shown as default in Admin CP which does show "English UK" as the 'Master Language' and there are no additional languages shown :o)

What was the resolution to Sales Ticket #99457?

To recap:
I would also comment that near line 181 in customers.index.inc.php:
$GLOBALS['db']->update('CubeCart_addressbook', array('default' => false), array('customer_id' => $customer_id, 'billing' => (string)$record['billing']));

Regarding array('default' => false), the default column is ENUM and false is not a valid value.

Suggest array('default' => '0'),

My experiments show that the javascript is looking for the add class in the two form elements. I am also finding that these two particular form elements need to be 'pre-valued' with '0'. That is:
input type="hidden" name="address[billing][]" id="billing" value="0" class="toggle add"
input type="hidden" name="address[default][]" id="default" value="0" class="toggle add"

The database table column 'billing' and 'default' are ENUM('0','1') and if the form POST does not include either of these elements, because the value of the element was never set to 1 or 0, the code in customers.index.inc.php usually puts a zero-length-string in the query. (Just like an earlier post in which the fix was to add the 'add' class.)

This ticket was prompted by the observation that, even though the admin had added several addresses to a customer's Address Book (admin.php?_g=customers&action=edit&customer_id=1#address), when that customer started the Checkout process, CubeCart complained there was no billing address.

Fields between mobile and desktop/tablet view are overwriting each other in the new default responsive theme.

To reproduce try changing shipping drop down on desktop and/or mobile.

This will be useful to see failures which can be fixed accordingly.

Cahing too much and not clearing when it should.

HTML formatting within the Content Box is not working, even when using Source Code setting - haven't tested any other documents yet.

Intentionally deleted, missing, moved? .htaccess form missing too.

Search tab is at top, but sidebar does NOT pop open when clicked.
Everyone is used to Search on right - Suggest you make box more prominent, a color change perhaps???? Also, some liked click and others liked hover on v5 popup (like that it's no longer on right and in the way) - Could this be an optional setting?

https://dirtybutter.com/plushcatalog/v6/admin.php?_g=#sidebar

<script type="text/javascript">
var file_list = {$JSON_IMAGES}
</script>

Can result in the following code with JS error.

<script type="text/javascript">
var file_list =
</script>

In /classes/db/mysql.class.php, line 186 (and mysqli.class.php, line 180):
echo "empty";
I question the legitimacy of this statement.

In admin, Email Templates, Email Contents tab, the alt attribute of the various flag <img> tags are shown because the flag images have been removed.

Line 230, suggest creating a style rule in the main CSS file for the skin:
debug { from line 230 }

Also, line 272 needs a <br /> at the end of Queries (count).

Also, suggest not having lines 267 and 268 as this creates an unnecessary line break.

I see in dashboard.index.inc.php, a new source for checking the version:
Request('www.cubecart.com', '/version-check/'.CC_VERSION)

However, maintenance.index.inc.php still uses:
Request('cp.cubecart.com', '/licence/version/'.CC_VERSION)

Also applies to CC5216.

Probably not an issue -- yet.

I THOUGHT this was going to allow the admin to create a new email to send from within Admin, based on some need in our store, even if I had to send it manually. Ideally I would have been able to use a Snippet to trigger this email in some way.

I like to email abandoned cart Pending customers, as I sometimes complete a sale by doing so.
I went through the process of adding a Template, expecting it to save and show in the list of emails as Admin: Abandoned Cart email. All my new template info DID save, but in order to save at the Email Templates tab, I had to uncheck the Default Emails and check my Abandoned Cart email.

When I looked back at the Email Content tab, my new Abandoned Cart email is not there, and there doesn't seem to be any mechanism for connecting it to Admin:, User:, etc.

I don't understand what purpose creating another Default email Template would be. Did I just misunderstand this new feature, or is it not working correctly?

Forums topic: https://forums.cubecart.com/topic/49103-browser-compatibilty-issues-when-displaying-storefront-under-version-600b1

Something to do with latest jquery..

On edit product categories

I used the token, rather than downloading, to add the US English language. It does show up in the files, but does not show up on the Manage Plugins page. It does not show on the Languages folder in Store Settings until I Clear Language Cache in Maintenance. Might be a good idea to indicate that in the Marketplace blurb on the Language files.

It would be helpful to put this info on the Store Logos tab of Store Settings. And I'd like to know it now for experimenting.

I have US English language installed, but only UK choice shows up when I try to put Documents in new language.

A request:

My programmer's text editor (UltraEdit) can match on start/end delimiters and HTML tags. For example:

<div>
{foo < this && bar > that}
</div>

such that when the text cursor is on the <div>, it is highlighted as well as </div>.

Unfortunately, it relies on counting the < and > characters and not so much on the actual tag itself since the tag could contain attributes.

So, using the less-than and greater-than characters in the Smarty syntax will confuse the matching feature.

Therefore, I humbly request that the in-house programming style adopt the usage of employing lt and gt and the other alpha-only variants of expression comparisons wherever possible:
{for $i=1 to 5}
{if $PRODUCT.review_score gte $i}
{elseif $PRODUCT.review_score gt ($i - 1) && $PRODUCT.review_score lt $i}
as examples.

Checkbox, Edit, Trashcan, Download on right column does not line up with default UK language.