cthulahoops / rocket Goto Github PK

I noticed that if you change your name, the pet's name still reflects the old one. So if you change your name from X to Y, then Y will be followed around by animals like "X's penguin". This name was also used in chat, so the old name gets propagated when abandoning said pets.

I'm not sure what the right solution here is. I guess one could be to poll periodically for the names and update correspondingly.

Today, Nicholas was mowed down by an errant deer and exploded (as of writing, the evidence of impact remains on the floor in the Pet Adoption Agency and by his desk).

This morning, I myself was both set on fire and aggressively thanked.

I'm not sure precisely when the second strike happens, but it's long enough after the first for one to let their guard down.

I think it would be easier for contributors (or people reading through the code generally) to know what animals aren't available if the list were sorted by name of animal.

I can make a PR for this if it is accepted as an issue that will add value to the project.

The duplicate / backwards in time check is too aggressive.