csunetsec / bgpmon Goto Github PK

View Code? Open in Web Editor NEW

28.0 6.0 4.0 12.06 MB

CSU's BGP Observatory code (bgpmon/pheme)

Home Page: https://www.bgpmon.io

License: BSD 2-Clause "Simplified" License

Makefile 0.37% Go 99.37% PLpgSQL 0.26%

bgp monitoring database rpc protocol-buffers

bgpmon's People

Contributors

Stargazers

Watchers

Forkers

willyingling acoul unclepieman amiduai

bgpmon's Issues

Testing Fail Conditions

Many tests in BGPMon, particularly the ones in db/ only check that the actions within them do not return any errors. They do not verify the behaviour of the things being tested.

Compile Failure: CSUNetSec/netsec-protobufs v0.1.4 lacks `bgpmonv2.Entity`

bgpmon/go.mod

Line 5 in e67c7d7

github.com/CSUNetSec/netsec-protobufs v0.1.4

You can see in a PR such as CSUNetSec/netsec-protobufs@v0.1.4...master that the Entity message is added after the v0.1.4 that listed in go.mod therefore db/dbstructs.go lines 193, 194, 227 cannot compile.

"util" Package

By the coding standards referenced in CONTRIBUTING.md, a package named "util" shouldn't exist. This package should be renamed, or broken up into more descriptive packages.

Recommend Projects