cs-au-dk / jalangilogger Goto Github PK

The LogFileTransformer needs to make href-attribute (or the more general javascript:) event handlers be logged with a properly transformed source location.

See example in chromeExperiments/bomomo.html:

<a href="javascript:saveCanvas()" class="toolbarButton" id="toolbarButtonSave" title=""><img src="./bomomo_files/save.png" alt=""></a>

Log:

{"name":{"valueKind":"concrete-string","value":"saveCanvas"},"sourceLocation":{"fileName":"js-url-0_orig_.js","columnNumber":"1","lineNumber":"1"},"value":{"valueKind":"abstract-object","value":{"objectKind":"allocation-site","allocationSite":{"fileName":"bomomo.html","columnNumber":1,"lineNumber":450}}},"entryKind":"read-variable"}

Problem:
The {"fileName":"js-url-0_orig_.js","columnNumber":"1","lineNumber":"1"} should be the inlined HTML source position: bomomo.html:2848:29 instead.

@barslev can you take a look? It should be similar to the other transformations that are already being done.

Run a strict test with a jalangilogger that respect strict mode to see the problem.
Before that disable the joinUndef mentioning this issue.

Receiving some exceptions like this:

Something went wrong during transformation of line: {"entryKind":"write-variable","name":{"valueKind":"concrete-string","value":"i"},"value":{"valueKind":"abstract-primitive","value":"1"},"sourceLocation":{"fileName":""},"index":-1}: java.lang.NullPointerException

Problem is when reproducing log files on tajs.Stats$Libs in the symbols_wip branch.
This could be a problem in other branches or a problem introduced by:

• the special jalangi2 version used in that branch
• the special ValueLogger used in that branch
• by the benchmarks (that use symbols!) that we use in that branch

The issue is workarounded at the moment by emitting a warning rather than throwing an exception, the effect of this being discarding a few lines from the log file.

The following execution of postProcessHTMLLogs results in an IndexOutOfBoundsException. It works for other test cases

Node-version: v4.4.5

./scripts/instrumentHTMLFiles.sh
./scripts/startServer.sh

Open browser. Interact with application. Click p

./scripts/postProcessHTMLLogs.sh

results in

Exception in thread "main" java.lang.IndexOutOfBoundsException: Index: 3, Size: 3
        at java.util.ArrayList.rangeCheck(ArrayList.java:653)
        at java.util.ArrayList.get(ArrayList.java:429)
        at dk.au.cs.casa.jer.TransformHtmlLogFiles.transformSourceLocation(TransformHtmlLogFiles.java
:149)
        at dk.au.cs.casa.jer.TransformHtmlLogFiles.iterateThroughJSONObjectAndChangeSL(TransformHtmlL
ogFiles.java:122)
        at dk.au.cs.casa.jer.TransformHtmlLogFiles.transformFile(TransformHtmlLogFiles.java:96)
        at dk.au.cs.casa.jer.TransformHtmlLogFiles.loopThroughAllFilesAndTransformThem(TransformHtmlL
ogFiles.java:45)
        at dk.au.cs.casa.jer.TransformHtmlLogFiles.loopThroughAllFilesAndTransformThem(TransformHtmlL
ogFiles.java:51)
        at dk.au.cs.casa.jer.TransformHtmlLogFiles.main(TransformHtmlLogFiles.java:29)

From: cs-au-dk/TAJS-private/issues/202

Too many unicode characters are accepted as STR_IDENTIFIER in the valuelogger: \xA0-\uFFFF are accepted.

This is to avoid interferences of the logging with the program.

The log for 10k/heatmap.html states that the constructor call at 51:22 has a callee allocated at 51:22, which is clearly wrong!

        var buffer = new Canvas({width: c.w(), height: c.h()}), // line 51

Similar oddities occurs throughout the log file.

(NB: Canvas is an user-allocated function, it is not the DOM Canvas)