cryptape / bft-rs Goto Github PK

pub fn send_status(&mut self, status: BftMsg) -> Result<()>{ match status { BftMsg::Status(s) => Ok(s), _ => Err(BftError::MsgTypeErr), } .and_then(|s| { if s.height >= self.height { self.height = s.height + 1; } self.sender .send(BftMsg::Status(s)) .map_err(|_| BftError::SendMsgErr) }) }

If the sender occurs an error, the height of BftActuator may different from Bft. Why not straightly expose Bft's height?

Here

@rev-chaos @KaoImin

For example:

usize: on a 32 bit target, this is 4 bytes and on a 64 bit target, this is 8 bytes.

Why should I learn how to use the channel?

Recommend the API to be changed to the following.

pub trait BFT {
    fn set_proposal(p: Proposal) -> BFTResult<bool, Error>;
    fn set_vote(v: Vote) -> BFTResult<bool, Error>;

    fn start();
}

pub trait BFTProvider: Send + Sync {
    fn package_proposal(height: u64) -> BFTResult<Proposal, Error>;
    fn validate_proposal(p: Prposal) -> BFTResult<bool, Error>;
    fn commit(cm: CommitBlock) -> BFTResult<(), Error>;
    fn udpate_validate(height: u64) -> BFTResult<Vec<Validate>, Error>;
    // Broadcast blocks or votes can be split into two function.
    fn broadcast() -> BFTResult<(), Error>;
}

let provider = BFTProvider::new();

let bft = BFT::new(provider, signer);
bft.start();

ref go-cita-tendermint

For example:

Address and Target:

What will happened if I input a Some(Vec::new())?

Hello,

I'd like to get in touch with @KaoImin . I was wondering if there's any contact information that can be provided.

Please email at [email protected]

Best,
Andres.