crusheerpl / demgen Goto Github PK

Consider refactoring the code to be able to add ther countries easily - now it has hardcoded PL and CZ, in the future someone would add other countries. To do that, think about dividing code into classes and namespaces.

This will make project more robust, but also more scalable.

This is idea for the future, not bug

It would be nice feature if we had possibility to enter only center of map, not border points.

Now user is forced to do math (with KML exporter, etc...) which can be done (from my point of view) in script.

This is idea for the future, not bug

Since some time there's a problem with elevation data collecting from Czech Geoportal – the 'getSamples' query type (used by demGen) is "forbidden by administrative rules" – so you can see 403 Forbidden instead of the data.

For example: https://ags.cuzk.cz/arcgis2/rest/services/dmr5g/ImageServer/getSamples?geometry={points%3A[[-712578.2488101454%2C-1060696.0999415524]%2C[-712576.265963167%2C-1060696.3606542302]%2C[-712574.2831160902%2C-1060696.6213661672]%2C[-712506.8662573174%2C-1060705.4851337026]]%2CspatialReference%3A{wkid%3A5514}}&geometryType=esriGeometryMultipoint&sampleDistance=&sampleCount=&mosaicRule=&pixelSize=&returnFirstValueOnly=false&f=pjson

I'm working on the big demGen update, I'll look for any solutions.

You must insert tile number for mod2 script to generate heights. It would be nice feature to have posibility to simply insert folder path and script will generate heighs

a

As of now, scripts have hardcoded config path (demGenerator_config.txt) and workspace folder (demGen_data). It would be nice to be able to configure where to load configuraiton and where to store intermediate results (if needed). Current values can be used as defaults

Environment:

Python 3.8

Reported by:

RomanCZ via YouTube (https://www.youtube.com/watch?v=4WGZ4wCk-Es&lc=UgwTAvRJvJdw-RSFuqt4AaABAg)

(Screenshot taken by RusheerPL in Win7 (64bit) PC)

Reason:

The mod2 has no support for Python 3.8 or newer, and Python older than 3.5. 44fcaf0

Solution:

Run this script in the Python 3.5 - 3.7 environment instead of Python 3.8.

When generating heights for the map (country=CZ), script (mod2) tends to create download peaks.

I would expect constant network usage when downloading heights data. Also consider bit refactor of mod2. In the script, "stupid" str.split is used to get data out of json. Thats one thing, another thing is, that in case when you will generate 4x4 map (my case), it will open ~4227136 connections just to get one number. Web protection services can detect this ammount of connections as an attack and will cause slow down for that user.

TODO:

• In the documentation find way how to download bulk of datas
• Refactor mod2 to be able to download just one datafile with all necesary heights

Impact:

Because of this issue, this script hard to use for large maps in czech environment.

jak kończe z tymi dem generator 1 itd to ak patrze tam gdzie mają być pliki ortho to jest sam zielony ekran help