crusat / python-zodiac-sign Goto Github PK

You can add this in order to support Zodiacs in Greek:

el_dict = (
    (0, "Κριός"),
    (1, "Ταύρος"),
    (2, "Δίδυμοι"),
    (3, "Καρκίνος"),
    (4, "Λέων"),
    (5, "Παρθένος"),
    (6, "Ζυγός"),
    (7, "Σκορπιός"),
    (8, "Τοξότης"),
    (9, "Αιγόκερως"),
    (10, "Υδροχόος"),
    (11, "Ιχθείς"),
)

language_dict = {
    'en_US': en_dict,
    'ru_RU': ru_dict,
    'pt_BR': pt_dict,
    'pt_PT': pt_dict,
	'el': el_dict,
	'el_CY': el_dict,
	'el_GR': el_dict,
    None: en_dict
}

I suggest when there isn't support for a specific locale to fallback to english:

def _(word_index):
    language = locale.getlocale()
    return language_dict.get(language[0], 'en_US')[word_index][1]

It would be nice if there would be some way to set up localization for the zodiac strings that the library returns.

I'm not sure if this is technically possible to do, but I'd suggest using some dedicated program like gettext.

Otherwise, a way to set a locale when requesting a zodiac string would also work.

The code needs to be changed like this:

def _(word_index):
language = locale.getlocale()
return language_dict.get(language[0], language_dict.get('en_US'))[word_index][1]

As of now the code is
def _(word_index):
language = locale.getlocale()
return language_dict.get(language[0], 'en_US')[word_index][1]

For me,
language = locale.getlocale()
language[0]

'English_United States'

For the code as of now, 'English_United States' is not included in the language_dict dictionary. So a string 'en_US' is returned. And you can see there will be errors later.