crpropa / rootoutputplugin Goto Github PK

The included FindROOT.cmake is a bit broken (there are two else() statements). I can make a pull request if you'd like, but I think the fix is just:

diff --git a/FindROOT.cmake b/FindROOT.cmake
index 2caa1d8..922efe1 100644
--- a/FindROOT.cmake
+++ b/FindROOT.cmake
@@ -20,6 +20,4 @@ else()
   message(STATUS "  CFlags:      " ${ROOT_CFLAGS})
   message(STATUS "  Libs:        " ${ROOT_LIBS})
   message(STATUS "  Incdir:      " ${ROOT_INCDIR})
-else()
-  message(STATUS "ROOT: Not found!")
 endif()

Hi,

I know this says it's not maintained by the CRropa developers, but are you accepting pull requests to keep it in a working state? Right now, it's very broken (first due to the deprecation of CRPropa2 outputs, then due to the SWIG builtin issue, then due to segfaults due to improper locking and deleting auto-freed things). I've gotten it working (for me, at least) on my fork (https://github.com/cozzyd/ROOTOutputPlugin) although it looks like there is more cleanup I could do to put it into a "proer state" (e.g. to subclass everything from the Output class in crpropa3). I know responding to pull requests can be a burden though, so I understand if you just want to WONTFIX this.

Thanks,
-Cosmin