crowdin / flutter-sdk Goto Github PK

Currently, this method returns null if an exception occurs during the translation download.

It would be great to provide a way for a developer to access the exception details. This will improve the DX and allow to better handle these exceptions.

Code: loadTranslations(...)

The https://pub.dev/packages/uni_links package is almost deprecated - the last update was published 2 years ago. Since it is a transitive dependency in the crowdin-sdk, it causes some issues. E.g. for Android, apps cannot be migrated to Gradle 8.4. Are there any plans to remove this package and replace it with an alternative?

Describe the bug
For instance, take the following localization: {rating} ({reviews, plural, =1{1 review} other{{reviews} reviews}}). CrowdinSDK returns this as only {reviews, plural, =1{1 review} other{{reviews} reviews}}.

Examples (how {rating} ({reviews, plural, =1{1 review} other{{reviews} reviews}}) is formatted):

To Reproduce

1. Having the rating value as "4.8" and the reviews value as 48...
2. Add the following localization key to your Flutter project:

"profileRating": "{rating} ({reviews, plural, =1{1 review} other{{reviews} reviews}})",
"@profileRating": {
  "description": "Profile rating + number of reviews.",
  "placeholders": {
    "rating": {
      "type": "String",
      "example": "4.8"
    },
    "reviews": {
      "type": "int",
      "example": "48",
      "format": "compact"
    }
  }
},

3. Use this key by passing the rating and reviews variables.
4. Notice that the localization key is rendered correctly
5. Translate the localization key in Crowdin, and distribute it via the over-the-air content delivery: {rating} ({reviews, plural, =1{1 review} other{{reviews} reviews}})
6. Check the rendered result now. It is stripped and only the plural section of the key is rendered.

Environment

• Crowdin Flutter SDK: 0.3.1
• Flutter version: 3.13.9
• Dart version: 3.1.5

Additional context
I don't think any additional info is needed, but let me know if you want something to be clarified.

Currently, this class has low coverage by Unit tests - Codecov report

Class - crowdin.dart

Tests examples - https://github.com/crowdin/flutter-sdk/tree/main/test

Describe the bug
When using the Flutter ARB file format for translations together with the CDN 'select' translations will not work for the translated languages. They are correctly displayed and formatted in Crowdin itself and work when exporting bundles, but not with the CDN.

To Reproduce
Steps to reproduce the behavior:

1. Configure the SDK with correct distribution hash and load translations for a specific language.
2. Load check 'select' translation in the Flutter app itself. E.g.

"roamingChoice": "{choice, select, month{For 1 month} unlimited{Unlimited} deactivate{Deactivate} other {}}",
  "@roamingChoice": {
    "placeholders": {
      "choice": {
        "type": "String"
      }
    }
  }

Expected behavior
Load in the translation select not as a static String.

Environment

• Crowdin Flutter SDK: 0.5.1
• Flutter version: 3.16.8
• Dart version: 3.2.5

Screenshots

Smartphone (please complete the following information):

• Device: Pixel 6
• OS: Android 14

Currently, this class is not covered by tests - Codecov report

Class - crowdin_storage.dart

Tests examples - https://github.com/crowdin/flutter-sdk/tree/main/test

Hi and thanks for the Flutter SDK,

I have an issue with it, knowing that I'm not using the real-time feature.
So basically, it's a call to https://distributions.crowdin.net/{distribution_hash}/content/{path_to_file}.

However, even if my distribution is updated, I still receive the old one.
If instead, I call https://distributions.crowdin.net/{distribution_hash}/content/{path_to_file}?timestamp={timestamp_from_manifest}, it's now OK.

Is-it an API issue or is there a specific reason you don't use the timestamp parameter?

Method:

Place in code:

Config:

If the developer sets the OrganizationName in the config, we should also pass it to the getMetadata method to properly resolve the metadata endpoint.

Currently, the SDK requires the [project, tm] scopes for authorization (code).

These scopes provide too much access and are redundant. We need to check which API method the SDK is really using and only need a minimal amount of scopes.

Understanding Scopes