croma-app / croma-color-picker Goto Github PK

Similar to this with supporting both HSV and RGB color options on the slider.
https://codesandbox.io/s/slider-color-picker-react-256yc

The feature request is also part of croma review:

It is hard to know which color you just selected now. Some outline or selection will be good.

I'm getting a Warning: Each child in a list should have a unique "key" prop error when running in my simulator.

This is probably because of the 4 occurrences of .map in lines 38-49 that render components without a key prop.

Adding the index of the map as a key would probably fix this.

Thanks for a good component, it works well.

However, I think there's a slight limitation in that the user can't pick white or black as their color.

Of course it's possible to just write #ffffff for white and #000000 for black in the text area but it would be nice to be able to pick those colors among the squares.

Perhaps the lightest and darkest square of each palette could be white/black?

E.g. with the default palette (for color #db0a5b), the darkest color available is #330014 and the lightest color available is #ece4e7, but perhaps they could be #ffffff and #000000?