Giter Club home page Giter Club logo

piko's People

Contributors

akir45 avatar chemchetchagio avatar crimera avatar dependabot[bot] avatar dic1911 avatar eddy00007 avatar fuwamocoanon avatar ibasim avatar indusaryan avatar isjasonyeh avatar kitadai31 avatar lgerniero avatar mehlsine avatar mrerenk avatar okkidwi avatar osumatrix avatar quasar-0330 avatar r7kings avatar riolove1 avatar semantic-release-bot avatar serkanege avatar swakshan avatar swakwork avatar taku-nm avatar uvzen avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

piko's Issues

Bug `Download patch` acts weirdly

Compared to revanced patches ReVanced/revanced-patches@2c20844 and this ReVanced/revanced-patches@d0f91c8 , download video feature patch is weirdly. In same post, i can't download the video with crimera patch, but while using revanced patches i can download the video.

I am using the revanced CLI and this command:

java -jar revanced-cli-4.4.0-all.jar patch -p -o X_10.30.0-release.0-all-archs-crimera.apk --options options.json -b revanced-patches-1.9.0-dev.1.jar --alias=[snip] --keystore-password=[snip] --keystore-entry-password=[snip] --keystore=[snip].keystore -m revanced-integrations-1.2.0.apk com.twitter.android-10.30.0-release.0-all-archs.apk -i "Hide For You" -i "Google Ads Patch" -i "Hide Banner" -i "Hide Live Threads"

Example post link:
https://twitter.com/le_sserafim/status/1763784207703441728

Screenshot from crimera X:
Screenshot_20240302-135743

Screenshot from Revanced X:
Screenshot_SS

I dont know if this bug already reported, but thats happened on my device.

Material you default blue color too bright

When material you patch is selected, the default blue is much brighter than the Twitter normal blue. Too bright.

Posted it on the telegram already but I thought maybe I should make it an issue here.

Sponsored Tweets with No Ads patches installed

OnePlus 8T - OxygenOS 14.0

  • Device Info
    ReVanced Manager: 1.20.1
    Model: KB2003
    Android version: 14
    Supported architectures: arm64-v8a, armeabi-v7a, armeabi
    Root permissions: No

  • Patch Info
    App: com.twitter.android v10.34.0-release.0 (Suggested: Any)
    Patches version: v1.20.0
    Patches added: Bring back twitter, Custom sharing domain
    Patches removed: Remove Detailed posts, Remove view count, Enable Reader Mode, Hide For You
    Default patch options changed: None

  • Settings
    Allow changing patch selection: true
    Version compatibility check: true
    Show universal patches: true
    Patches source: crimera/piko
    Integration source: crimera/revanced-integrations

  • Logs
    Reading APK
    Decoding app manifest
    Loading patches
    Merging integrations
    Deleting existing temporary files directory
    Decoding resources
    Executing patches
    Applied 22 patches
    Compiling patched dex files
    Compiled 12 dex files
    Compiling modified resources
    Aligning APK
    Signing APK
    Patched APK
    Installing patched app
    Installed

Crashes when loading either feeds (For You - Subscribed)

OnePlus 8T - OxygenOS 14.0

Device Info
ReVanced Manager: 1.20.1
Model: KB2003
Android version: 14
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

Patch Info
App: com.twitter.android v10.34.0-release.0 (Suggested: Any)
Patches version: v1.20.0
Patches added: Bring back twitter, Custom sharing domain
Patches removed: Remove Detailed posts, Remove view count, Enable Reader Mode, Hide For You
Default patch options changed: None

Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: true
Patches source: crimera/piko
Integration source: crimera/revanced-integrations

Logs
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing temporary files directory
Decoding resources
Executing patches
Applied 22 patches
Compiling patched dex files
Compiled 12 dex files
Compiling modified resources
Aligning APK
Signing APK
Patched APK
Installing patched app
Installed

[BUG] Feature flags string inconsistency in localized strings.xml files

Hello crimera,
I believe Feature flags string's value in mod menu is fetched from strings.xml in values-v21 folder (piko_title_feature_flags) and not from localized strings.xml files (piko_pref_feature_flags), and that's what makes it keep its original English value.

I checked mod menu in a few languages that have piko_pref_feature_flags string translated, and this issue persists in all of them:

ResizedImage_2024-04-15_06-55-34_0
ResizedImage_2024-04-15_06-55-34_1

Hide Community Notes & Hide Live Threads fail on latest version.

SEVERE: Hide Community Notes failed:
app.revanced.patcher.patch.PatchException
at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:187)
at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Patcher.kt:205)
at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
at app.revanced.cli.command.PatchCommand$run$4$1$1.invokeSuspend(PatchCommand.kt:303)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280)
at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:302)
at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
at picocli.CommandLine.access$1500(CommandLine.java:148)
at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
at picocli.CommandLine.execute(CommandLine.java:2170)
at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)
Caused by: java.lang.NullPointerException
at crimera.patches.twitter.misc.hidecommunitynotes.HideCommunityNotePatch.execute(HideCommunityNotePatch.kt:46)
at crimera.patches.twitter.misc.hidecommunitynotes.HideCommunityNotePatch.execute(HideCommunityNotePatch.kt:17)
at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:173)
... 24 more

SEVERE: Hide Live Threads failed:
app.revanced.patcher.patch.PatchException
at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:187)
at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Patcher.kt:205)
at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
at app.revanced.cli.command.PatchCommand$run$4$1$1.invokeSuspend(PatchCommand.kt:303)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280)
at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:302)
at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
at picocli.CommandLine.access$1500(CommandLine.java:148)
at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
at picocli.CommandLine.execute(CommandLine.java:2170)
at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)
Caused by: java.lang.NullPointerException
at crimera.patches.twitter.timeline.live.HideLiveThreadsPatch.execute(HideLiveThreadsPatch.kt:46)
at crimera.patches.twitter.timeline.live.HideLiveThreadsPatch.execute(HideLiveThreadsPatch.kt:18)
at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:173)
... 24 more

Installation instructions are missung.

Sorry to come here and bring such a dumb question to this section, but nothing in the Readme or in the entire internet clarify how to install and use these patches with Revanced Manager?!!
i tired the Alternative Resources but I'm confused with the correct steps and I still can't make it work. So I need help PLEASE

Bug: Duplicate App Icon

Changing App Icon from settings creates a dublicate icon for twitter.

Steps to reproduce:

  1. Change App icon for twitter in settings. Let's say , change it to black.

  2. close the app and then reopen and go to mod settings and dont change anything just close the app after that

  3. now if you see it in app drawer 2 icons for twitter will be displayed.
    Default pink one and the black one which you have set it.

Screenshot_2024-03-31-10-30-09-97_b783bf344239542886fee7b48fa4b892

Bookmarks in a nav bar won't load

If a bookmark icon is put in a nav bar it won't load and gives an error: "Folders aren't loading now. Try again later." Using the latest version from piko-builds releases.

Screenshot_2024-05-08-12-45-48-933_com twitter android-edit

Hide Reposts

Add the ability to hide reposts, with the following child options:

  • Hide reposts in timeline
  • Hide reposts in user profiles
  • Hide reposts in lists (#140)

And anywhere else where they might show up.

A scenario where this feature would be useful would be when going through an accounts' posts/replies, as this would eliminate the need to scroll past the stuff they repost in order to get to their actual content.

Feature requests

Add the option to remove the Lists, Spaces, Monetization, Ads under the Professional Tools tab, and Grok (or give free access to Grok if possible).

And anything else I might have missed. Worth looking at Aerowitter as an older version of a very full featured hacked Twitter app.

Add toggles in the mod settings for these options

It might sound odd, but having a toggle for each option is much more user friendly and less time consuming because if someone changes their mind they don't have to go through the patching process and repatch again the app.
Also, all of these options have toggles on v10.28.0.

These are the options to add toggles in the mod settings:

  1. Show sensitive media
  2. Selectable Text
  3. Clear tracking params
  4. No shortened URL (added)

Crash when click on Piko mod settings

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.twitter.android/app.revanced.integrations.twitter.settings.SettingsActivity}: android.content.res.Resources$NotFoundException: String resource ID #0x0

at android.app.ActivityThread.performLaunchActivity(Unknown Source:621)
at android.app.ActivityThread.handleLaunchActivity(Unknown Source:47)
at android.app.servertransaction.LaunchActivityItem.execute(Unknown Source:63)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(Unknown Source:77)
at android.app.servertransaction.TransactionExecutor.execute(Unknown Source:73)
at android.app.ActivityThread$H.handleMessage(Unknown Source:43)
at android.os.Handler.dispatchMessage(Unknown Source:19)
at android.os.Looper.loop(Unknown Source:242)
at android.app.ActivityThread.main(Unknown Source:101)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(Unknown Source:11)
at com.android.internal.os.ZygoteInit.main(Unknown Source:275)

Caused by: android.content.res.Resources$NotFoundException: String resource ID #0x0
at android.content.res.Resources.getText(Unknown Source:36)
at android.content.res.MiuiResources.getText(Unknown Source:11)
at android.content.res.Resources.getString(Unknown Source:0)
at app.revanced.integrations.shared.Utils.getResourceString(Utils.java:186)
at app.revanced.integrations.twitter.settings.SettingsActivity$Screen.strRes(SettingsActivity.java:478)
at app.revanced.integrations.twitter.settings.SettingsActivity$Screen.onCreate(SettingsActivity.java:349)
at android.app.Fragment.performCreate(Unknown Source:13)
at android.app.FragmentManagerImpl.moveToState(Unknown Source:357)
at android.app.FragmentManagerImpl.addAddedFragments(Unknown Source:46)
at android.app.FragmentManagerImpl.executeOpsTogether(Unknown Source:129)
at android.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(Unknown Source:99)
at android.app.FragmentManagerImpl.execPendingActions(Unknown Source:21)
at android.app.FragmentManagerImpl.dispatchMoveToState(Unknown Source:18)
at android.app.FragmentManagerImpl.dispatchActivityCreated(Unknown Source:4)
at android.app.FragmentController.dispatchActivityCreated(Unknown Source:4)
at android.app.Activity.performCreate(Unknown Source:67)
at android.app.Activity.performCreate(Unknown Source:1)
at android.app.Instrumentation.callActivityOnCreate(Unknown Source:3)
at android.app.ActivityThread.performLaunchActivity(Unknown Source:376)
... 11 more

Doubled command patch

With standar patch you mention in notes:

java -jar cli.jar patch \
  -b official-revanced.jar \
  -b piko.jar \
  -m integrations.apk \
  -e "Unlock downloads"
  -o out.apk input.apk

There are doubled patch which is Hide Recommended Users like this:

image

You should add exeptions for that, e.g

java -jar cli.jar patch \
  -b official-revanced.jar \
  -b piko.jar \
  -m integrations.apk \
  -e "Unlock downloads"
  -e "Hide Recommended Users"
  -o out.apk input.apk

Either piko patch or revanced patch you excluded.

Mod settings

Can you add mod settings? Not every time patching with revanced

bug: Custom download folder patch and others failing

When ever I try to patch with custom download folder patch ends up failing with app.revanced.patcher.patch.PatchException: 'Custom download folder' depends on 'SettingsPatch' that raised an exception: (see the txt file below for the whole error). If I remove this patch and try patching without, it fails with the same error but on a different patch.
info_memory_limit.txt

"Disable auto timeline scroll" doesn't really work

I didn't notice any difference when enabling or disabling this option.
SwipeRefresh loading is gone, but it still jumps to the top of the timeline on app launch.

Twitter version : 10.41.0-release.1
Patches version : v1.29.0

Double App Icon.

Please I selected the patch for custom icon, and I noticed that this produces TWO app icons for X in my apps list—the stock icon and the custom one I selected.

Please how do I stop this from happening? I'm using the version 10.37.0-release.0

Thank you in anticipation.

Monet Patch Issues

Introduction: This is a port of an issue I submitted to revanced-patches.

In the latest Twitter apk, the code has changed and the background of messages I send via DM is still Twitter Blue (#ff1d9bf0) even after changing the definition in color.xml.
After much research I discovered that some of these colors are now defined in last classes.dex.
I would like to be able to change the color of these BGs as before, is it possible to apply "@android:color/system_accent1_400" & etc. in this code?
303999564-a442681c-2ec1-451c-8207-ff0c836e2dfd

(Suggestion) Add patch to revert the X name and icon back to the original

Currently there's a way of doing this is only by modifying an already modified by the patcher apk yourself, however it's a pretty timeconsuming and automating it via revanced patcher would be much preferable.

PS: By revert the X name and icons i mean reverting the UI completely including splash screen topbar icon, the app name and icon itself

Feature Flags

Hi

Thank You
Can add Features flags like twifucker?

i want this

explore_relaunch_enable_immersive_player_across_twitter

RVX Manager

How can I build the app using RVX or revanced manager? I'm not comfortable with revancify.

Roadmap

Hello, would it be possible to have a roadmap in the description to see what's left until this is 1:1 with the existing mod? Just a simple checklist with emojis would work as well.
Thank you

reset pref and flags Issues

Hi, I found that in the simplified chinese translation of twitter app, notification_settings_preferences_category was translated as tweets instead of Preferences.
Deleting notification_settings_preferences_category directly does not meet the requirements.
The flags section deletes the piko_title feature_flags in values-v21. Most translators did not translate this. Is it more appropriate to use piko_pref_feature_flags?
IMG_20240519_085401

Add `Show poll results` to mod settings and kebab menu

Add Show poll results to mod settings like the other patches, and then add a toggle in the post's kebab menu to view the poll results.

I'm assuming many would rather not always see the results before voting on something, so having it hidden by default seems fair.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.