createlogic / inlinesvg Goto Github PK

As title.

Can you add me to collaborators list of this repo to maintain this project? I'll be glad to do some stuff about publish to bower, may be make some other improvements.

Please add git tag 'v1.0.0' for this commit: a4fc329
And please add git tag 'v1.1.0' for this pull request: #3

It's helps for using bower or other package manager by specific version.

Love this plugin and want to contribute! Currently, any events attached to the tag that is being replaced are lost. In addition, there is no callback when the swap is completed. Sooo, I submit this additional code for your inspection and hopefully approval:
starting at line 31
....
// Remove any invalid XML tags as per http://validator.w3.org
$svg = $svg.removeAttr('xmlns:a');

    // NEW Copy any event listeners over 
    $.each($._data($img.get(0), 'events'), function() {
        // iterate registered handler of original
        $.each(this, function() {
            $svg.bind(this.type, this.handler);
        });
    });

            // Replace image with new SVG
            $img.replaceWith($svg);

    // NEW Pass along the "done" event from the "get"
    $svg.trigger("done", [$svg]);

.....

When the image object gets replaced with the svg, any event listeners (eg. 'click', 'keydown', etc) that had been on the original image object are lost.

That could probably be solved with a one-liner before the swap:
$img.copyEventsTo($svg);

Untested though...