craeyeons / ped Goto Github PK

I suspect a use of double spacing between "User:" and name "Koh Rui Jie" in this case. Purely a cosmetic issue.

I like the idea of capitalising module prefixes and suffixes for consistency. However, instead of forcefully forcing the user to input the module codes with capitalised prefix and suffix, I suppose you could process this easily while parsing the input using a capitalisation function of String in Java?

It's quite inconvenient to constantly hit the shift key to capitalise a few letters when the commands are all in lower case keys.

For example in the "adding user" command, name is not an optional field, however square brackets are used to surround it which contradicts the instructions of the user guide.

After executing nextsem, then undo. The modules moved from Current Modules to Previous Modules do not move back to Current Modules after calls to Undo.

To reproduce:

1. nextsem
2. Observe that modules have shifted after clicking on all of the users (due to previous bug).
3. undo
4. Realise that modules that have shifted do not shift back. Not even on click.

The field that is too long here is the github username not the name of the contact.

To reproduce:

1. Run the following command. add n/Joe p/12345678 a/JurongEast e/[email protected] g/123123132132131321313131321323232132132123132123132123123132132132132132132132132132132123132132123132123132132132123

I am allowed to add CS1231 into the list of modules despite not taking the module.

As the title suggest, I realised that I am only able to add one module at a time which greatly hinders the speed of using the application via typing.

Instead of typing,

1. module user curr/CS2100
2. module user curr/CS1231S
3. module user curr/CS2040S

I suppose it is feasible to implement
module user curr/CS2100,CS1231S,CS2040S

I am allowed to add two lessons of the same timing.

After executing nextsem, Current Modules of all users do not shift until I click on them.

To reproduce:

1. nextsem
2. Observe that current modules do not shift.
3. Click on each user and observe that current modules shift to previous modules.

After adding a lecture slot to user's timetable, undo command does not remove the added lecture.

To reproduce:

1. add any lesson, e.g. lesson user l/lec m/CS2103T d/1 start/18:00 end/19:00
2. timetable user to verify that the timeslot has been added.
3. undo
4. timetable user and realise that the same lesson is still on the timetable.

When executing the command filtercurrmod CS4231 CS1101S, it shows 0 users despite the fact that Irfan Ibrahim (in the default setting) does that CS1101S.

However, the UG states that "Filters the current modules of contacts to return a list of persons with any of the current modules specified by the user."

I am able to add QWE1234 which is clearly an invalid module. This contradicts the reinforcement in the user guide.

It appears that I am able to add the same module code (CS2101) to all 3 of Current Modules, Previous Modules and Planned Modules, which isn't feasible in real life. I suppose this should be checked and fixed.

Steps to reproduce:

1. module user curr/CS2101
2. module user prev/CS2101
3. module user plan/CS2101