Using an array of hardcoded names is not a good solution in regards to maintainability and scalability.

I'd rather use something like "msg.from.first_name", as its used in the function "/choose".

Currently, i don't have time to rewrite it by myself.

Maybe save the old warning and check if it changed and only then send a message

There are a lot of global variables that do not need a global scope, e.g. "loremSettings/doit/ship/editions/merge".

Maybe, we can think of a solution for variable "geste", because it is needed in three functions.

Some features are missing

The bot is currently not sending the weather forecast at the designated time

Expected:

Bot is sending forecast at the designated time

Problems should be in the usage of sendWeather function within the scheduler (see line 134)

Hopefully this will work
https://www.npmjs.com/package/svg-to-png

We might want to move all arrays to contents.json to clean up the sourcecode.

Now it is needed to handle errors properly (see #58), it is also necessary to generate errors scriptside because the log won't write these errors (see #55)

Actual state:
If the bot token is invalid, the log file will be flooded with an Error: ETELEGRAM: 404 Not Found and a massive error json.
over 200k log messages in a few seconds 👎

Desired state:
If the bot token is invalid, the bot shall stop and return with an error code.

We might want to enhance the /choose function to work with more (if possible n) options for better usability

Example input:

/choose foo, bar, why am i doing this, this is also a option

Desired output:

one of the 4 inputs

For every function the bot offers (e.g. /stone, /choose) we save the values "msg.from.first_name", "msg.from.username" and add a subroutine in every function that adds the name to the file "users.json".

e.g. /choose for example

bot.onText(/\/choose (.+), (.+)/,(msg, input) => {
  var answer = Math.random() >= 0.5 ? input[1] : input[2];
  bot.sendMessage(msg.chat.id, "@shipitbot has chosen *"+answer+"* for "+msg.from.first_name,{parse_mode : "Markdown"});
  });

could be written as:

bot.onText(/\/choose (.+), (.+)/,(msg, input) => {
  addToUsersJSON(msg.from.first_name, msg.from.username);

  var answer = Math.random() >= 0.5 ? input[1] : input[2];
  bot.sendMessage(msg.chat.id, "@shipitbot has chosen *"+answer+"* for "+ msg.from.first_name,{parse_mode : "Markdown"});
  });

Therefore we would have to write a function called addToUsersJSON that could look like following:

function addToUsersJSON(firstname, username) {
  var myObject=require('./users');
  for (i in myObject.users){
    if (myObject.users[i].username==username){
      var contains = true;
    };
  };

  if (!contains){
    myObject['users'].push({'username': username,'first': firstname});
  };
  var json = JSON.stringify(myObject);
  fs.writeFile('users.json',json);
}

Don't expect the above code to work out of the box. The code above is untested!

Because i am to lazy to do it myself.

Add a new value to the users.json objects e.g. subscribed=true/false to check if a user wants warnings

Each time the bot would send a warning it sends it to every subscribed user

I'd like to see some GIFS, too.

For example, you could use a bunch of following:
https://giphy.com/search/ship-it

I think that pushing information about a storm/bad weather in general would be a great feature.

The information can be acquired from e.g. following site
http://www.unwetterzentrale.de/uwz/getwarning_de.php?id=UWZDE96050

Input: /choose Kaffee, gruener Tee, schwarzer Tee
Output: @shipitbot has chosen Kaffee, gruener Tee for Manuel

Expected Output: Kaffee OR gruener Tee OR schwarzer Tee

We should look into proper exception handling for all functions, because at the moment the console spam is real.
Also i consider to fork wttr.in's repo to ensure that the image source is available.

There are functions with english names like "decide/choose/etc.".
But, there are also functions with german names like "wer/schere/stein/papier".
Furthermore, there are function names that are non describing, like /marius

Maybe, we should keep consistency with the language?

@Sceinox - I don't want to mess with the script :D
It would be useful to rewrite the automated deploy script to write log and error files.
For reference: https://stackoverflow.com/questions/10122245/capture-node-js-crash-reason

I have to review the code, i might even rewrite the function.

tl:dr: fuck that shit!

TypeError: cannot read property 'names' of undefined

we need some error handling for this

Remove var, cleanup code, make methods formatted uniform

The weather warning feature spams too much in case of fog

It might be useful to check if the headline contains the keyword "Nebel" anderen then don't send the warning

We need more cats http://random.cat/meow

might be better to keep the main folder cleaner