Giter Club home page Giter Club logo

snaplinksplus's Introduction

Snap Links Plus

Snap Links is a Browser Addon that lets you lasso links, checkboxes and other elements and do things with them.

See our website for news, tutorials, release notes, etc.

Need Help - Issue Tickets

I'm looking for some people to help triage new issues and label them appropriately, answer them if they are feature related, confirm them if they are bugs. It would be a huge help to the project. I had time recently to work on the project and found myself spending time going through tickets instead.

If you're interested, please reach out to me by opening a ticket about it.

Thanks!

snaplinksplus's People

Contributors

astrodogx avatar btanner2 avatar cpriest avatar dependabot[bot] avatar martin-mfg avatar michelepezza avatar phyxion avatar rautava avatar remi-garcia avatar reporterx avatar yfdyh000 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

snaplinksplus's Issues

Snap Links Plus disables Tab Mix Plus

when Snap Links Plus and Tab Mix Plus are both installed and enabled, the normal functionality of Tab Mix Plus (i.e. dragging and reordering tabs between windows) is disabled. This makes firefox extremely difficult to use for me, as I normally have 50-100 tabs open and I drag & drop them constantly between windows, but I also need the ability to open multiple links.

OS: Ubuntu 12.04 LTS
Firefox 25.0
Snap Links Plus 2.3.4b10
Tab Mix Plus 0.4.1.2.02

remove repositories form other websites

So I have used this add-on for a while and when it stopped being compatible with FF25, I started looking for the dev website and found these:
https://addons.mozilla.org/en-US/firefox/addon/snap-links/
https://addons.mozilla.org/en-US/firefox/addon/SnapLinksPlus/
http://snaplinks.mozdev.org/
http://code.google.com/p/snaplinksplus/
https://github.com/cpriest/SnapLinksPlus

I finally found this website! (should have looked at Moz Addons homepage link)
If it is possible please remove the really old Moz Addon page of original since you have those versions hosted here as well as remove MozDev and GoogleCode pages.
So you would be left with the OFFICIAL development site of SnapLinkPlus here and the download page at Moz Addons

Snap Links Plus issue with page zoom

I have encountered a bug with Snap Links Plus 2.3.4b4 on Firefox 25.0. When I have either zoomed in or out on a page by any degree, the area where the rectangle is drawn is off from where the cursor actually is. The further I am zoomed in or out of the page, the more it deviates from the cursor's actual position.

Here's where the rectangle draws on a page that is not zoomed:

normal snap

And here's what happens if I zoom out about 3 times on the same page:

wacky snap

Note this only occurs if I zoom everything on the page. Zooming just the text on a page is apparently fine.

Edit: I didn't notice initially, but the red selected links are correct based on the mouse position, and it's just the rectangle and links label that are in the wrong position.

right links wrong rectangle

"Save Links" doesn't work

Reported by guy.jh.marty, Nov 28, 2012

What steps will reproduce the problem?
1.Select links
2.Choose "Save link" (in French "Enregistrer les cibles des liens sous")
3.Nothing happend

What is the expected output? What do you see instead?
I expected that a popup open to choose the destination folder
Instead, nothing happend

What version of the product are you using? On what operating system?
Snalink plus 2.3.1
Firefox 17.0
MS Windows XP SO3

What is the page URL where this issue is occuring:
All pages

Today (14 hours ago) Delete comment
#2 itchybig

I'm having the same issue.

Snap Links Plus 2.4.0
Firefox 26.0
Windows XP SP3

Thanks.

SnapLinksPlus 2.3.4b6 - Issue selecting links together on pages

Hi there, I found an issue that seems to occur on many pages, but I'll use this page as an example:
http://www.idarionis.com/hydra/

SPL seems to have some trouble selecting all of the links on pages for me. It seems that if I enlarge the rectangle enough to encompass two different elements of a site (for example, both the main body and the navigation buttons), the links from one element will be deselected, and I cannot select them again unless I redraw the rectangle.

On this page, I start selecting the left navigation links from the left pane...no problem so far:
untitled1

But, if I enlarge the rectangle enough to also grab the links in the main body, the left links are deselected:
untitled2

This seems quite dire, so I wonder if I'm doing something wrong, now. By the way, I'm at normal zoom on those pages. :)

TypeError on XUL pages

I see such error on a XUL page (ex: chrome://global/content/console.xul) when right clicking:

Error: TypeError: this.Document.body is undefined
Source file: chrome://snaplinksplus/content/snaplinks.js
Line: 187

I didn't noticed any side effects of the error so it's probably not important issue.

Link selection does not match the real lines

Hello, I have a bug that is new in the FF25 / SLP2.3.4b6.
On some pages, like http://www.rouming.cz/, the selection does not work - I am dragging the bar and the real selection made is smaller and/or elsewhere. It looks like scale problem, because the closer to bottom of the page, the more inaccurate the selection is.

Let me point out this bug is new here - it was always 1:1 selection in previous versions.

BR, jimo:)

Add math functions for non-links

Probably too large of an enhancement request, however, the interface provided for by SLP would be ideal for simple math, in particular addition. ie: add up all the numbers in a selected area

FF 29: Minor Visual Issues

Border for selection rect overlaps browser document rect on the top and possibly other sides.

Need to test with varying resolutions as well, zooming in/out, devPixelsPerPx, etc.

Count bug(s)

I've noticed on occasion that the counter is incorrect for the number of links selected. There are technically three bugs and a bit of confusion here:

  1. The count will be count + 1 on occasion. I can't duplicate the issue reliably, however, when I do observe the issue it is always occurs when Firefox is reflowing the page while the selection is in process (ie: from scrolling below the line or similar)

  2. This appears to be a "feature" but is more of a bug in my view: If absolute/relative URLs are present they are counted and any javascript and id links are ignored. If an id link is present without any absolute/relative URLs then javascript links are ignored.

  3. JavaScript counting is inconsistent due to links that do not use href values being ignored. ie: a onclick="javascript:Foo();" is ignored while a href="javascript:Foo()" is counted.

  4. There can be some confusion around the "Remove duplicate links" option as it relates to counts. One could think that the count is post removal of duplicates, which would be incorrect of course.

To resolve most of these issues I think a simple change could be made to the UI so that it displays more information than simply a total count would resolve these issues and add functionality:

Basic User version:
Total: A (Without B Duplicates: A-B)

Advanced User version: //read developer version, would require an option to be added
Total: A (Without B Duplicates: A-B)

  • HTML Links: C (Internal: D, External: E, Duplicates: F)
  • JavaScript Links: G
  • breakdown of each type rel link

SnapLinksPlus not working with FF 25.0 Beta

SnapLinksPlus not working with FF 25.0 Beta, last worked with FF 24.0 Final release just fine. My settings are:

Selection Tab - Start selecting with - "No keyboard button, right mouse button"
Action Tab - Default Action - "Ask me what to do"
Advanced Tab - all settings are default

The selection rectangle is drawn but I'm not presented with the normal action menu.

I've tried versions 2.3.3 and 2.3.4b2 with same behavior. Also, there are reports on Mozilla's Addon site that FF 26.0 is experiencing this same issue. Thanks Clint.

Doesn't work with FF21

Reported by scooters.comp, Apr 3, 2013

What steps will reproduce the problem?

  1. Just doesn't work anymore. I right click to select the link, and there is no more red dotted rectangle

What version of the product are you using? On what operating system?
latest 2.3.1

What is the page URL where this issue is occuring:
any page
for example mozilla.org

I'm using this firefox:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/21.0b1-candidates/

Apr 5, 2013
#1 Mr.Nolff

Works fine with FF20 but does not work with the FF21b.

Apr 7, 2013
#2 beyond.immortality

Installing 2.3.2b15 (available in 'downloads' above) just now fixed this issue for me, I had the same trouble otherwise.

Apr 9, 2013
#3 QuizMasterAshwin

CONFIRMED! 2.3.2b15 solves the problem in Firefox 21.
Here's a direct download link for:
http://snaplinksplus.googlecode.com/files/snaplinksplus-2.3.2b15.xpi

Today (5 hours ago)
#4 tlk91759

This version of Snap Link Plus quit working when the newest version of Firefox downloaded. Please fix it right away as we use it to play a game that I alone have almost 1800 friends to play with

border disappears

as has happened on ealier versions, the selection border tends to disappear every now and then

Open links in order selected via drag

https://addons.mozilla.org/addon/SnapLinksPlus/reviews/568326/reply

A user has left a review for your add-on, Snap Links Plus.

Rating:
4 out of 5 stars

Review:
Multi Links, dead since 2011, is an extension that did what this does, except would open links in the order you dragged them, so you could go right to left, and the first opened tab would contain the rightmost link, because you dragged over it first. This is the only flaw of this extension, as far as I can see. Adding this ability, at least as a toggle, would make it perfect for me.

https://app.leanboard.io/board/c29e6bcc-1437-486b-a4aa-dfed2de11d4d

"Save Links" does not working

Reported by guy.jh.marty, Nov 28, 2012

What steps will reproduce the problem?
1.Select links
2.Choose "Save link" (in French "Enregistrer les cibles des liens sous")
3.Nothing happend

What is the expected output? What do you see instead?
I expected that a popup open to choose the destination folder
Instead, nothing happend

What version of the product are you using? On what operating system?
Snalink plus 2.3.1
Firefox 17.0
MS Windows XP SO3

What is the page URL where this issue is occuring:
All pages

Not working on Reddit subreddits

I know this is a really minor problem, but the drag box doesn't seem to work on any subreddits. It does work on the front page of Reddit, but anywhere else and it simply doesn't function.
The error console returns this:
ForElement.SnapRects is undefined Selection.js:535

Define multiple actions

It would be pretty nice if we would be able to define multiple actions:
For example opening links in background when using the right-click selection, copying links with left-click selection and downloading them with middle-click selection.

Just something that would allow multiple actions to be defined.

using snaplinks on link groups containing empty link tags causes the starting webpage to be reopened

I use snaplinks with one my custom webpage containing various link groups, in order to reopen them everyday. I recently found out that if I use snaplinks over one of these groups, and in the group there's an anchor link with href attribute empty, that link causes the opening of a copy of my custom webpage (i.e. a second one is opened). The other link, as in in the example I give, works normally.

Here's the code example:

google\

This example has one correct href anchor node and one empty href anchor node. The issue appears with the same result also with 0 or >1 correct links (anchor nodes with href having value, with one ore more empty anchor nodes).

Many thanks,

     Marco

Issue with beta9 with FF25 on Win8

I wanted to report an issue with SnapLinksPlus 2.3.4b9 with FF25, running on Windows 8.

It works fine, except that the starting point is not aligned with the cursor. So, if I'm hovering over a link and right-click, the box actually "starts" about an inch above the cursor. If I move the cursor, the box grows normally, but from the incorrect starting point.

Thanks for maintaining this great little add-on.

Still having issue with zoomed pages with 2.3.4b7

I am still having issues with zoomed pages as with the previous build. I change the size through about:config and changing the "layout.css.devPixelsPerPx" setting. When i change it to 1.0 there is no problem with selecting links.

Right-click malfunction under a spoofed user agent environment

Hi,

Problem Summary: Have to right click twice to popup the native context menu, when the firefox user agent is spoofed as Linux and choose SnapLinksPlus Start Selection With Right Button.

Environment: Windows 8 & Firefox 26.2 ESR

Steps to Reproduce:

  1. install user agent spoofer, e.g. random-agent-spoofer
    https://addons.mozilla.org/en-US/firefox/addon/random-agent-spoofer/
  2. fix the spoofed user agent as Linux
  3. open SnapLinksPlus options and choose Start Selection With Right Button, then save
  4. visit whatever web page
  5. hit left click once in the content area and then a right click
    -> the context menu won't show
  6. hit the right click again
    -> the context menu shows after the 2nd right click
  7. repeat step 5-6 to reproduce the flip-flop situation
    By the way, SnapLinksPlus drag to select works as design.

Reproducible: Always

Possible Cause:
Found codes shown below in snaplinks.js to detect the platform and use as a flag to sink the mouse event later.
if(e.button == 2 /* RMB */ && this.ChromeWindow.navigator.userAgent.indexOf('Linux') != -1) {
this.StoppingNextContextMenuPopup = true;

Since navigator.userAgent might report a fake value and is no reliable, you might want to use nsIXULRuntime instead.
https://developer.mozilla.org/docs/XPCOM_Interface_Reference/nsIXULRuntime

Thanks!

Issue on Youtube

I'm having a major issue with SnapLinks and Youtube.
a. At Youtube, went to "My Subscriptions"
b. Clicked "Uploads only"
c. Clicked "Load more" button 10 time to get to some older content
d. Quick right clicked on a video to get the context menu (wanted to open it in new tab)
e. At this point SnapLinks selection box popped up and went nuts. The green selection box appeared and I could not get it to disappear. The selection box moved with my mouse cursor but I was not holding down the mouse button (my start selecting trigger is just the right button). Firefox UI became unresponsive. Task manager reported memory usage for Firefox process was quickly climbing. Around the 3GB mark Firefox crashed.
f. This behavior was repeatable several times.
g. Disabling SnapLinks, I am able to browse Youtube, with the same steps above, without any issues.

Windows7 / Firefox 28 / SnapLinks 2.4.0

2.3.4b3 and 2.3.4b4 work with FF28; 2.3.4b5 and 2.3.4b6 DO NOT ?!

I know FF28 is in nightly/latest trunk stage,
but what I noticed is that only two latest beta work with it, and then b5 breaks it again:

b2 doesn't
b3 does
b4 does
b5 doesn't
b6 doesn't

Can you look into it?

Basically links don't get selected by the rectangle in b2 b5 and b6, while b3 and b4 work as expected

Snaplinks freezes when Rightclick (context) on embedded flash (swf)

Reported by [email protected], Feb 14, 2013

What steps will reproduce the problem?
1.play video on Youtube page.
2.Click Rightclick (context) on the video (the flash).
3.Click stop download on the context menu.

What is the expected output? What do you see instead?

Snaplinks freeze then not work .

What version of the product are you using? On what operating system?

All snaplinks versions, FireFox 15.0.1 and I checked on other previous version , Windows 7

What is the page URL where this issue is occuring:

http://www.youtube.com

Please provide any additional information below.

The main problem is context on swf flash video in any page include embed not only youtube will causes this issue.

border does not show

the green (or wjatever you choose it to look like) outline that surrounds the slected area tends to not show in the latest beta and firefox 25.0.0.1 . Selection still works normally, though and the border does return as soon as you make any changes in the settings

Chance to deselect links before executing the assigned action.

Currently, with SLP you only got the option of handling all links within the selection-area.

There's currently no way to deselect certain links before the assigned action is executed, as the action is fired upon mousebuttonup.

If the action wasn't to be executed until the modifier-key is lifted, there could be a chance to deselect links, or add more selections for other parts of the website.

Download all function not working

Reported by rnavarro3000, Nov 23, 2012

What steps will reproduce the problem?
1.Set default action to "ask me what to do"
2.Select links, pick Download All option

What is the expected output? What do you see instead?
Expecting links to be downloaded. Nothing happens.

What version of the product are you using? On what operating system?
2.3.1 and 2.3.2 b15. Windows7 64 bit with Firefox 17 32bit

What is the page URL where this issue is occurring:
Selection of any link will produce the problem.

Please provide any additional information below.
"I've been using Snap Links Plus to copy multiple links to the clipboard without any issues. I'd like to start using the download all function but its not working for me. My action is "ask me what to do". After selecting a link, selecting download all in the context box, nothing happens. Tried both with Firefox 16/17 without luck."

change tab- addon stops working completely

so I am using the latest beta, but this means that whenever I change the tab, load a new tab etc. and go back to whereever I want to use snaplinks, I cannot select anything. I will have to refresh the tab to make the addon work again

Link selection not working properly

When i have an indented list of links not all are being selected properly.

ss1

in the image above if i drag my selection around the whole block i get 1 link, i want them all. If i drag my selection block around the bottom section it gets 5. How can i select them all?

using firefox 24 on win7. this behavior has been happening for multiple versions.

How it works

Mr. Priest:

What do I need to do with the mouse to get the links into the clipboard. Letting go the mouse after I drag to subsume the links simply defaults to opening those links in new tabs. Yet you note that one can also caused the information to be added to the clipboard for pasting into a spreadsheet. I have yet to figure out how this is done, precisesly.

I tend to agree with the follow who was surprised there was no documentation whatsoever. Not even on GIT.

Thanks in advance. Harry Stein

Right-clicking can cause a delay on some sites...

Example: imdb.com/search/title?at=0&count=100

This is because as soon as the right-click-down event fires the document calculations are made, which take very little time but it is noticeable on pages with many elements. This could be delayed until the drag begins or possibly to a non-ui worker thread.

snap links activates in wrong region

I'm on Mac OS Mavericks in the latest firefox, and recently when I activate Snap Links Plus the field activates a few hundred pixels away from where I actually clicked. It's incredibly frustrating as I can never select what I'm actually hovering over! Any ideas?

Page reload prevented link selection

What steps will reproduce the problem?

  1. Set an automatic page reload by using check4change (https://addons.mozilla.org/firefox/addon/check4change/).
  2. Try to select links by snaplinksplus on the page of the step 1.
  3. Once the page refresh terminated the link selection, you can't select links anymore; the selection rectangle doesn't appear after the selection failure.

What is the expected output? What do you see instead?
Ideally, the selected links are kept even the page are refreshed during the selection, or at least, the new selection would be allowed after the termination.

What version of the product are you using? On what operating system?
Snap Links Plus 2.3.3b22
Firefox 22.0
Windows 7 Home 32bit

What is the page URL where this issue is occuring:
Any pages

Please provide any additional information below.
Hi, It would be appreciated if you could check the issue above. Thanks in advance!

Selection "drop" issue

I've encountered this a quite few times when select scrolling long documents:

I'll start selection and at some point the system will register that I lift the right mouse button and immediately press it again. This usually happens when using the 3 finger scroll or mousewheel, not the keys. As a result it's probably a driver bug you can't do anything about, however, after release the context menu doesn't appear to pop up, it instead immediately goes into a new selection box. I attempted adjusting the "Delay between actions" option but it seemed to have no effect on this particular issue.

Any ideas on how to keep this from happening or at least get the context menu to pop up?

Download action doesn't appear to work

I have Firefox 23.0.1 and Snaplinks 2.3.4b2 running on Arch Linux with the XMonad window manager. When i set the default action to "Download" and select, nothing happens. It works fine opening the links in new tabs.

Add "Modify Selection" Option

I believe versions of this have been requested before as "multi-select" options which would be difficult at best. I would simply like to see an option added to the context menu which says "Modify Selection" which would allow the user to manipulate the box they created as a typical selection box can be. ie: side/top/corner controls

The reason I think this would be a valuable option is that mouse-wheel scroll selection while holding right-click can often end up in accidentally releasing the right mouse button. Having to re-select from the top of a long document can be a pain if this keep happening.

Right click within the selection box after re-sizing with the left mouse button could then bring up the context menu again.

This would also allow for users who have difficulty scrolling, selecting with the right mouse button, or performing fine selections the ability to use the addon effectively.

Context Menu Changes

It'd be nice to have a bit more of a robust context menu such as:

  • Modify Selection //see #45
  • Open in...
    • New Tabs
    • Single New Window
    • Multiple New Windows //side note: add a warning/are you sure if more than 5 links are selected
  • Open as...
    • New HTML list
    • New text document
    • New CVS document
  • Save Links As... //this would bring up a prompt as the Firefox does on a single link right click to allow folder selection then files would be saved as their individual file types
  • Download All (count) //This would be different from "Save Links As" in that it would only download items which have the HTML5 download attribute
  • Copy Links As...
    • Text
    • HTML
    • List
  • Copy Text As... //If links are selected, text in the A tag is selected not the href also could be expanded later to include non-linked text from table or list selections
    • Text
    • HTML
    • List
  • Bookmark As...
    • Individual Links
    • Links in a folder //This would simply default to add links to a folder with the name of the site they were on (ie: github.com folder with X number of links in it)

This is a lot of functionality to add that isn't currently there but I've had use cases for each of them that this addon would have been perfect.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.