Comments (7)
tony-iqlusion
commented on May 28, 2024
1
@rnbguy that one's probably fine because it's in its own namespace, whereas the Validators struct/enum are in the same namespace and therefore the generated code doesn't compile
from cosmos-rust.
tony-iqlusion
commented on May 28, 2024
@jkilpatr @ChristianBorst are you aware of an upstream tracking issue in cosmos-sdk about the clashing names in the protos?
from cosmos-rust.
rnbguy
commented on May 28, 2024
There is also a related case - cosmos.base.abci.v1beta1.Result. It conflicts with std::result::Result.
from cosmos-rust.
beatriz-web3
commented on May 28, 2024
same issue
from cosmos-rust.
tony-iqlusion
commented on May 28, 2024
I opened an upstream issue here: cosmos/cosmos-sdk#12316
from cosmos-rust.
tony-iqlusion
commented on May 28, 2024
#275 automates the patching process, using the following names:
pub struct Validators(same as original generated code)pub enum Policy(as suggested in cosmos/cosmos-sdk#12316)
Still, it would be good to find a solution for this issue that doesn't involve patching generated code.
from cosmos-rust.
tony-iqlusion
commented on May 28, 2024
Going to go ahead and close this as there is now an automated solution.
Fixing the name clash is tracked as cosmos/cosmos-sdk#12316
from cosmos-rust.
Related Issues (20)
- TallyParams Undocumented Decimal Type HOT 2
- Enable cosmrs support `no_std` HOT 5
- Maybe Can Use only one crate `cosmos-sdk-proto` or `ibc-proto-rs` HOT 6
- Sync versions with tendermint-rs?
- wasm-bindgen issue when using cosmrs in CosmWasm HOT 10
- Type URLs for x/authz messages not present HOT 4
- Add additional derive macros to Prost generated types HOT 19
- gov/v1 HOT 2
- Does this crate only supports gRPC for querying contracts states? HOT 4
- proto build fails because of deprecated buf template HOT 1
- Update crypto lib HOT 2
- Error: failed to load state at height 0; version mismatch on immutable IAVL tree; version does not exist. Version has either been pruned, or is for a future block height (latest height: 0): invalid request HOT 1
- 405 Method Not Allowed HOT 2
- Update ibc-go types HOT 1
- Error with user entered invalid UTF8 for protobuf structs.
- bug: cargo run ends in an error
- proto-build: bump COSMOS_SDK_REV to v0.47 or higher HOT 3
- Querying `minimum_gas_price` HOT 3
- How to output the private key and print it to the terminal？ HOT 2
- Abandon `cosmos-sdk-proto` in favor of `ibc-proto`? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cosmos-rust.