codecademy-jammming's Introduction
codecademy-jammming's People
codecademy-jammming's Issues
Be able to delete playlist
Suggestion - instead of using setState immediate for adding a track, push, then set state
Seen here: https://github.com/Cordazar/codecademy-jammming/blob/master/src/Components/App/App.js#L30-L34
I think this could be done better by saving this.state.playlistTracks; as a variable, pushing to that variable, then calling setState and passing the updated version of the variable.
Error handling against Spotify API
Sorely lacking at the moment.
Add tests to application
To increase the dependability of the application and to open up for further development in TDD style.
Suggestion - add wrapping Number around urlExpiresIn[1] in Spotify.js
Seen here: https://github.com/Cordazar/codecademy-jammming/blob/master/src/util/Spotify.js#L16
I believe you want to cast this to a number.
Suggestion - for saving Playlists, want to set playList tracks to empty again.
Seen here: https://github.com/Cordazar/codecademy-jammming/blob/master/src/Components/App/App.js#L47
Since we're adding the playlist, we want to clear out the current songs in playList tracks.
Suggestion - return response.json() in search in Spotify.js
Seen here: https://github.com/Cordazar/codecademy-jammming/blob/master/src/util/Spotify.js#L31
We want to return this response, but it looks like you're not really doing anything with it here.
SUMMARY: Meets Expectations!
Nice work on this jammming project! I like how you chose to condense your codes (used simpler if else statements, tried to bind all the methods in app.js in a single line, etc. I also found your naming conventions to be pretty revealing of values.
In terms of improvements, I recommended some changes for savingPlaylists, a quick reminder to use setState when updating the values of variables, and how to efficiently update with setState. Wish you the best of luck as you continue, and keep up the good work! :)
View all account playlists
Suggestion - remember to use setState!
I noticed you're directly setting the variable, but you want to be sure to use this.setState! :)
Select playlist from current playlists
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.