corbosman / message_highlight Goto Github PK

After upgrading to 2.3, when I download the message attachments (images, documents), they dont open.

This only happens when downloading from roundcube, because I can open the same attachments using my Outlook.

I use roundcube 0.9

I like this plugin. It would be nice if the plugins choose text color to compliment background color for light and dark contrasting ...

Message Highlight is missing an icon in Roudcube's settings. I tried to take the hint from jappix4roundcube but I can't find where the icon is set in the PHP code.

Hi there,
I plugged this into my fairly vanilla debian bullseye roundcube; no other plugins. I can add rows to the Message Highlights table, but nothing changes in the message list display.
I tried adding console.log(message) to mh_insert_row() in the .js file. I can see dozens of rows in the browser console, but none have the .flags field that the js is expecting:

    // check if our color info is present
    if(message.flags && message.flags.plugin_mh_color) {

It looks like the php is trying to populate that field inside mh_highlight(). I tried shoving my own field in unconditionally:

      $message->list_flags['extra_flags']['plugin_mh_jonh'] = 'xxx-jonh';

...and that doesn't show up in the browser JS console, either.
So now I'm suspecting that the path from PHP 'extra_flags' to JS .flags has changed somewhere along the line, which makes me wonder whether I'm trying to debug something that has simply fallen behind the current roundcube hooks?

Thanks much!

I couldn't add another rule, the button does not work.

Please rewrite plugin for RC 1.3, which has no Q()
I suppose you should call rcube_utils::rep_specialchars_output($str, 'html', 'strict') instead

Roundcube: 1.5.0 (debian package)
PHP: 8.1

With the plugin enabled, the roundcube error logs get gently spammed with PHP warnings about the use of fetch_headers in the storage_init hook.

The fix is pretty simple, and I'll toss up a PR that has worked for me (and follows the pattern I've seen in other plugins that do the same thing).

in setting made a default rule for all users, so then , when loggin all users have a rule that macht such "warni9ng mails for alers"

obviously this will need a "confi8g.inc.php.dist" file and default settings... or maybe a default sql settings for users documented...

Hi @corbosman

I saw some roundcube plugin developers align them plugin project names to "roundcube-".

So, I suggest to you rename this project to "roundcube-message_highlight".

And thanks by your work.

glad this plugin exists, though i could think of several ways to make it more powerful

1. wildcards, obviously. maybe a regex option for the pros
2. option to apply a color to several addresses (comma-delimited list)

Are there any plans to add support of elastic theme? At this moment it's unusable and looks like(don't pay attention on existing rules. They were added with larry skin)

When I have no rules created and I press to add a new line(rule), the first line get displaced to the right.. but this doesnt happen when I have at least one rule created... Issue image attached.

By the way, this is an awesome plugin!!

The message highlights setting buttons to delete and add a row only work in the larry skin, they do not work in the classic skin. The other settings work in both skins.

Hello,

if a header (typically the Subject) includes a UTF8 encoded text, the highlight rule must be entered using the hexadecimal codes for UTF8 characters, e.g. if the Subject header is:

Subject: =?utf-8?q?Re=3A_Pros=C3=ADm_vyzvedn=C4=9Bte_si_p=C5=99ihla=C5=A1o?=
=?utf-8?q?vac=C3=AD_=C3=BAdaje_k_nov=C3=A9mu_po=C5=A1tovn=C3=ADmu_serveru?=
=?utf-8?q?_=C3=9AFCH?=

"přihlašovací údaje" has to be entered as "p=C5=99ihla=C5=A1ovac=C3=AD_=C3=BAdaje"

Is there any possibility to implement direct UTF8 support in the plugin?

Thanks,

with kind regards,
Lukáš Svoboda

What do i use at roundcube?

archive | 3.4
contextmenu | 3.2.1
filesystem_attachments | 1.0
jqueryui | 1.12.0
login_lang | dev-master  
managesieve | 9.3  
markasjunk | 2.0 
message_highlight | dev-master
newmail_notifier | 0.8
password | 5.1  
zipdownload | 3.4

What doesnt work?

Add new rules and colors on messages